From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id AB4FFF72
 for <dev@dpdk.org>; Tue, 31 Jul 2018 15:31:04 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id j5-v6so16690389wrr.8
 for <dev@dpdk.org>; Tue, 31 Jul 2018 06:31:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:mime-version;
 bh=5Nkx9Nuzr2yr7MWFennnb1wIAq1jlJQGdKrxIY9FOsQ=;
 b=XMWWvufWw/CCWzFT4QbHmz9eDHKZby5pYfxN+kskCakL4qCwBX9ygfajKzUk7+f5Nc
 RoIW/redwFcR1YKMgyvH4L2hfSjrKWFmCvlroaLBzzbOVar79g2ltc18a5xJO+56skco
 t9NXHzdvCPJO5+t2cotglCxTqELYF1449XCVurlBQcQRyWb0SBmlOaXSbK7cqporg8qH
 b1kmOZOdnOukpLF/kGcxIL5JyZTFLtdPHOAkdrDro/EywqdLrXyWgTMM98NZAOSvWk8r
 fCAgdDVDnlVJhvUQcj3Gdojc1u4RrgoNvODRBeoY3EDLB7vj6GVlgJ1yonB6V6puxjUP
 zUCg==
X-Gm-Message-State: AOUpUlH3m4Zjn9axlf2oLePs+1n9hi+RmJ4rGddZSQhmlMO78QPTBU2G
 yPOee8rnVNnw79RCeFbU5C4=
X-Google-Smtp-Source: AAOMgpcfycqSIA7cPr+COafkTvn+wfOf/8E9Ds+9A85jlRBZl3SWtcQtt5bGewLO26ch4brZSfwX3A==
X-Received: by 2002:a5d:4701:: with SMTP id
 y1-v6mr21144533wrq.107.1533043864481; 
 Tue, 31 Jul 2018 06:31:04 -0700 (PDT)
Received: from localhost ([2001:1be0:110d:fcfe:dc12:297:5785:c4fa])
 by smtp.gmail.com with ESMTPSA id d26-v6sm1957834wmb.15.2018.07.31.06.31.03
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 31 Jul 2018 06:31:03 -0700 (PDT)
Message-ID: <1533043863.20916.49.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Timothy Redaelli <tredaelli@redhat.com>, Shahaf Shuler
 <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Date: Tue, 31 Jul 2018 14:31:03 +0100
In-Reply-To: <b467b0280830c94fba9078707c8af85214ce4ed7.1533042803.git.tredaelli@redhat.com>
References: <b467b0280830c94fba9078707c8af85214ce4ed7.1533042803.git.tredaelli@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 13:31:04 -0000

On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> Stripping binaries at build time is usually a bad thing since it
> makes
> impossible to generate (split) debug symbols and this can lead to a
> more
> difficult debugging.
>=20
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
>=20
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> =C2=A0drivers/net/mlx5/Makefile | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 75bee4640..2e70dec5b 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -409,7 +409,7 @@ endif
> =C2=A0$(LIB_GLUE): mlx5_glue.o
> =C2=A0	$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> =C2=A0		-Wl,-h,$(LIB_GLUE) \
> -		-s -shared -o $@ $< -libverbs -lmlx5
> +		-shared -o $@ $< -libverbs -lmlx5
> =C2=A0
> =C2=A0mlx5_glue.o: mlx5_autoconf.h

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi