From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id F389DB539 for ; Thu, 19 Feb 2015 10:40:18 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id hi2so46641929wib.4 for ; Thu, 19 Feb 2015 01:40:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3NqiCuSr8NMeWJyWouaXK4OxTLYeB57mSdJY3WP+MCc=; b=g911RspzX/IbiB1vQydLHEAwUkfy9vXg0ls/pvOEaIQznduJBlED3Z8WYuyFr75N0M AUxbCy/AONlxPt8MBDiNh6XamtZ4eN71JjBZU/7KMfDBxVe58Hh59YDHftnKaSRElwPU b1FpJTSWLkHpse1JwYPz+2BFsrzUlNHd68VhFVMJCE5fbNNGy0RrUvA4L+Q63FsMyMWI Dp8K0+kN2RtB0ELhqk7z7fDHZXgeLOlFgk02L4LRRT7rcQeK1vuG6I1y9kbRGVRxVvCL PtxdH6rA/tIemknRSA5OePMX5/d3bcgHIrviUtNCSE1WkaULhfT1FbdKA/gJthvus6Aq NOpw== X-Gm-Message-State: ALoCoQmKyIgPkp3KFXIYyHJMe6FBPEJXktZf+ik6iW83n8xG3Ov/vj6LQyGcj3efnDf79gNbiHO0 X-Received: by 10.194.9.98 with SMTP id y2mr7293551wja.85.1424338818786; Thu, 19 Feb 2015 01:40:18 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bd8sm36565240wjc.21.2015.02.19.01.40.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Feb 2015 01:40:18 -0800 (PST) From: Thomas Monjalon To: "Jastrzebski, MichalX K" Date: Thu, 19 Feb 2015 10:39:49 +0100 Message-ID: <1533160.F3kMOSWkDY@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB1582138EA984@IRSMSX109.ger.corp.intel.com> References: <1423840570-6452-1-git-send-email-michalx.k.jastrzebski@intel.com> <1774392.VK6szrItcK@xps13> <60ABE07DBB3A454EB7FAD707B4BB1582138EA984@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 09:40:19 -0000 2015-02-19 09:18, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-02-13 16:12, Declan Doherty: > > > On 13/02/15 15:16, Michal Jastrzebski wrote: > > > > Michal Jastrzebski (6): > > > > net: changed arp_hdr struct declaration > > > > bond: add link bonding mode 6 implementation > > > > bond: add debug info for mode 6 link bonding > > > > bond: add example application for link bonding mode 6 > > > > bond: modify TLB unit tests > > > > bond: add unit tests for link bonding mode 6. > > > Hi Thomas, > > You didn't sign some of these patches. So I suspect that you should > > fix some authorship. > That's because I am not an author of all of these patches - 1/6, 5/6 and 6/6 You probably broke it by importing patches with "patch" command instead of "git am". Then you must fix the authorship in your git tree before sending. > > Some of the patches make some changes without explaining why. > I noticed 5/6 has got incomplete description. Probably it disappeared during edition. Yes please ask yourself why each patch is done, and check it's explained in commit log. > > > Series Acked-by: Declan Doherty > > > > Please, use checkpatch before submitting and/or when reviewing. > I was using checkptach.pl, and have no errors, but I will check again. > Maybe I overlooked something. > > > > A v3 is needed. > > Best regards > Michal