From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata
Date: Mon, 13 Aug 2018 18:03:45 +0200 [thread overview]
Message-ID: <1534176226-21911-1-git-send-email-david.marchand@6wind.com> (raw)
Add some basic check on the segments offset and length metadata:
always funny to have a < 0 tailroom cast to uint16_t ;-).
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
lib/librte_mbuf/rte_mbuf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index e714c5a..7eeef12 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -200,6 +200,8 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header)
pkt_len = m->pkt_len;
do {
+ if (m->data_off + m->data_len > m->buf_len)
+ rte_panic("bad segment metadata\n");
nb_segs -= 1;
pkt_len -= m->data_len;
} while ((m = m->next) != NULL);
--
2.7.4
next reply other threads:[~2018-08-13 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 16:03 David Marchand [this message]
2018-08-13 16:03 ` [dpdk-dev] [RFC 2/2] ethdev: check received mbufs sanity David Marchand
2018-08-24 10:17 ` David Marchand
2018-08-23 7:39 ` [dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata Olivier Matz
2018-08-23 7:45 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534176226-21911-1-git-send-email-david.marchand@6wind.com \
--to=david.marchand@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).