From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 5CB5E68CF for ; Fri, 11 Apr 2014 13:24:04 +0200 (CEST) Received: by mail-we0-f172.google.com with SMTP id t61so5272044wes.31 for ; Fri, 11 Apr 2014 04:25:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Cwe4hLYfhK2EDCOek3i/I66EP43Gwi9hCz1IHBeneuY=; b=cAVbZfrFi/2uA0cn37an4iglCWLdWXCrn5NdsEWD6jTEn2tqARgxkoVMyAssN7zs68 pYLWxmdbSNhC3iLvEek/l05aRf3QF1HvjHEEacArZQkpiFaUjNEBLMyYuh58xxXO13HG a4vvfR9/AFjabnagU8B8lZOHJbsY8T2TKWXBXPkQ/fHnFBKLm9Xid7wbsosFD3uxbXys Rki2aaitv6WgpjYLafcHDisgFjFSZW3LJfmNDtCUFW/Uzh9j+JUmaf5RvRV/Hyp5bUjA eUqbXBFmdeJc9ZrgBWmD43qzBKUaLn9hdOXpoOE21ML+nx08ZZ5B0a3IRtU3eB9dE3k8 xneg== X-Gm-Message-State: ALoCoQknHFIMZpb93k/kdI5KRyGHRfWZ7DxbuNjtbtY9aGIsrW6VWPLuIgR8gJk1kkuP0g7a7rWn X-Received: by 10.180.37.178 with SMTP id z18mr3026577wij.46.1397215541361; Fri, 11 Apr 2014 04:25:41 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id hm5sm10892551wjc.17.2014.04.11.04.25.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Apr 2014 04:25:40 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Date: Fri, 11 Apr 2014 13:25:39 +0200 Message-ID: <1534459.c4aMep7oeX@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.7-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <1397201793-26580-1-git-send-email-olivier.matz@6wind.com> References: <2329281.9S2dNLIOMh@xps13> <1397201793-26580-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 06/11] vdev: rename nonpci_devs as vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2014 11:24:04 -0000 2014-04-11 09:36, Olivier Matz: > The name "nonpci_devs" for virtual devices is ambiguous as a physical > device can also be non-PCI (ex: usb, sata, ...). A better name for this > file is "vded" as it only deals with virtual devices. > > This patch doesn't introduce any change except renaming. > > Signed-off-by: Olivier Matz You probably should change the BSD Makefile also: lib/librte_eal/bsdapp/eal/Makefile:SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_nonpci_devs.c Thanks -- Thomas