From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9293C107A for ; Fri, 27 Oct 2017 10:53:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CBB7C20D8B; Fri, 27 Oct 2017 04:53:12 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 27 Oct 2017 04:53:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=9B6x7gBElSDcW2h/2hLddD2qYy 7rPdlfQZISC0M7pa8=; b=B/zPg/nHA+XvOprut127SMOIKC56c5MW821b4Q51pc DppRb4jnagiymvvUkl+szF/QOf4E04gT4J+VLhn5vv91tD6D2ToApI/EuGZWKuhG K0sRa1H6OVVLZzXMqKgBv6+5lPKrOntTfhG9msYOXXpWhIet5BMFrhxowgAysiJ9 o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9B6x7g BElSDcW2h/2hLddD2qYy7rPdlfQZISC0M7pa8=; b=VWJntAEz3eZgNCzaaCzTBc QtbBmpUFIWDjpBLeW548FX4FNXzB7aGPUV/1WYBJ/d2hvnm556M8m7s9pY3xAmJp wDP6HHzegVnRVDHs3g4phxvxdUneMSK/vF4n4MEuHIwaQHtm4+2o5JY+csr7lQj1 vCsL9f81z0wkSSbM/3Vaidhe9KDuJRUd9zjVSugzg1lrtyyTtbaccePPfmHqOHhu DnEenwdBHYgaLengffZym7tTLSgUdODDvnPQ3hEHJfsSr8sfhxf/0kUMz4lYsMjL VDMynwKKqdBvwlJ04zUe9zmvETLjioq2wqiHgDrIaCrcjt5Mq5IReuDf8hnV8Vjw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B6697E13B; Fri, 27 Oct 2017 04:53:12 -0400 (EDT) From: Thomas Monjalon To: "Tan, Jianfeng" Cc: dev@dpdk.org, "jblunck@infradead.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "De Lara Guarch, Pablo" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" , "Yigit, Ferruh" , gaetan.rivet@6wind.com Date: Fri, 27 Oct 2017 10:53:11 +0200 Message-ID: <1534566.pSR1OR4QPK@xps> In-Reply-To: References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1536098.KmeRH1tTdf@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 08:53:13 -0000 27/10/2017 10:19, Tan, Jianfeng: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 27/10/2017 03:06, Jianfeng Tan: > > > --- /dev/null > > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > > > @@ -0,0 +1,8 @@ > > > +DPDK_17.11 { > > > + global: > > > + > > > + rte_vdev_init; > > > + rte_vdev_register; > > > + rte_vdev_uninit; > > > + rte_vdev_unregister; > > > +}; > > > > It should not be needed to export the driver ops. > > rte_vdev_register/unregister are needed by vdev PMDs, which are needed to export, isn't it? Yes you're right, I overlooked it. > And for rte_vdev_init()/rte_vdev_uninit(), do you mean we all change to use rte_eal_dev_attach()/detach()? rte_vdev_init() is mostly used in tests. I changed my mind, you can keep it. Maybe it would be clearer to rename rte_vdev.h to rte_bus_vdev.h to mimic what was done for PCI. So rte_bus_*.h are mainly for PMDs and not to be used by common applications. > > Please can you try to make it private? > > Even we want to make it private, I think it needs deprecation notice, which we can further improved for the next release? Yes we can revise usage of rte_vdev_init(), rte_eal_dev_attach() and rte_eal_hotplug_add() in the next release. Gaetan, do you have any comment?