From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 657FC20F
 for <dev@dpdk.org>; Wed,  4 Mar 2015 10:25:22 +0100 (CET)
Received: by wivz2 with SMTP id z2so9694816wiv.0
 for <dev@dpdk.org>; Wed, 04 Mar 2015 01:25:22 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Ft8GFT6juLsQQ4FgzEIQZoeBQ0T85q8JL+ZGwkEKfhY=;
 b=NmG33qaL6tHa9IX/M4rJNPdD+NY0yLryMzTuYayDed5hBHwqT0LCOuCVjfoKL4h18s
 mhAUu9HuaiijxnZ1O9UDh8utxfDIJckNXiZTHJMVeDgEt+FVqxpTUNmxRe5QOV7nAOPS
 XL1usCaR+dWqKd0qFdIe1ZWupoyxiu4BUDUTyNk7pTu+MvcPaITJYOvDjW/As6P3m7S7
 dpnPrkmn2FbWOP/z5n//a/yd/NogX62NPp45Z1yVH0yVOZ/wtiXN4EsLMH87IQaeFb47
 ypcV5b8pNMvFhqK2n/oi/cMqK060Xs5UnQFuOEPq2vA1tHEl5L4e9phUHc6MEizpfXOh
 Tywg==
X-Gm-Message-State: ALoCoQl1N777jG2+gRkLW5hD1XeNT352olEckBvjxm4vpx6bfhPrdfTBYduWQzg7CtMs5sOSRkFh
X-Received: by 10.180.103.40 with SMTP id ft8mr55125594wib.68.1425461119251;
 Wed, 04 Mar 2015 01:25:19 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id cb9sm24313739wib.10.2015.03.04.01.25.16
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 04 Mar 2015 01:25:17 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Date: Wed, 04 Mar 2015 10:24:44 +0100
Message-ID: <1534932.rt5IAT3UZl@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <c826d83d78b0d24d0d840775b6ff6afaa848320c.1425449872.git.pmatilai@redhat.com>
References: <c826d83d78b0d24d0d840775b6ff6afaa848320c.1425449872.git.pmatilai@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: default to shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2015 09:25:22 -0000

Hi Panu,

2015-03-04 08:17, Panu Matilainen:
> With symbol versioning its vital that developers test their code in
> shared library mode, otherwise we'll be playing "add the forgotten
> symbol export" from here to eternity.

Yes we must improve the sanity checks.
A lot of options must be tested (or removed) and not only shared libs.
But the error you reported before (missing export of rte_eth_dev_release_port)
cannot be seen even with this patch.
It means we need more tools.
Though, default configuration is not a tool.

> By defaulting to shared we should catch more of these cases early,
> but without taking away anybodys ability to build static.

Shared libraries are convenient for distributions but have a performance
impact. I think that static build must remain the default choice.