From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id A9EEA58C6 for ; Thu, 30 Aug 2018 19:31:05 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id n11-v6so2812397wmc.2 for ; Thu, 30 Aug 2018 10:31:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=JYlyUy4/sfhY9L9VIZulnPuFydjD5JA8gcJx+UQCVSU=; b=TXFffDmBRaTrs04uYuu17SqldDKh3Fx8tSFTt0We+sVV9ZTIoQcdQb/A4D/yqVFR8w +WP1PADhqYB5RXUMU13JSPhEVXTli79m0v4pXYUFprKeIXo9vosk/DMOTVKrIEnEx+D3 uBFpkNeqvVfiYmzOkgaCyG9WyiqlnFwF7H7t3QkSDFhSYoFXG/WEmfov4sCX0j8/dmrw /sTEwrmz5NYlZD4hfz6WpUucG+QsePYDhYSTwINViFIQ5EWjT0rOcag22nbXfI468fCq ya5uCAxrni14j/me+5sUUsvpfDaSu+yd+icL3ntX1uAcsjQtyXm1uDUR7IOlbsXRET3w +XAg== X-Gm-Message-State: APzg51CHDcrk7in0/disvAwBNZUn5D6x0DBdmhtQz2RKgrxUHHZA1SU/ LRwPUi3VN42z6+45Y9uDOB8= X-Google-Smtp-Source: ANB0VdYaG5IPDm+qs8WIxhfrXyssSP4sn3p0QdCEDTXlMNJxvoZXT3qviG3y8W0gD8Vg0Fy4mC470Q== X-Received: by 2002:a1c:b709:: with SMTP id h9-v6mr2325052wmf.130.1535650265324; Thu, 30 Aug 2018 10:31:05 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id b144-v6sm3226599wmd.23.2018.08.30.10.31.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 10:31:03 -0700 (PDT) Message-ID: <1535650263.11823.18.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Thu, 30 Aug 2018 18:31:03 +0100 In-Reply-To: <20180830170701.21443-1-bruce.richardson@intel.com> References: <20180830170701.21443-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 17:31:05 -0000 On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote: > For meson builds, the define to enable the symbol version > macros in rte_compat.h was missing. This led to symbols being > omitted from shared objects. For example, checking rte_distributor.so > with objdump and comparing make and meson built versions: >=20 > $ objdump -T make-build/lib/librte_distributor.so | grep _flush > =C2=A00000000000001b60 g=C2=A0=C2=A0=C2=A0=C2=A0DF .text 00000000000000a7 > (DPDK_2.0)=C2=A0=C2=A0=C2=A0rte_distributor_flush > =C2=A00000000000003f10 g=C2=A0=C2=A0=C2=A0=C2=A0DF .text 0000000000000434= =C2=A0=C2=A0DPDK_17.05=C2=A0=C2=A0 > rte_distributor_flush > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush > =C2=A00000000000001d50 g=C2=A0=C2=A0=C2=A0=C2=A0DF .text 00000000000000fb= =C2=A0=C2=A0DPDK_2.0=C2=A0=C2=A0=C2=A0=C2=A0 > rte_distributor_flush >=20 > Adding in the missing define fixes this. >=20 > Fixes: 5b9656b157d3 ("lib: build with meson") >=20 > Reported-by: Luca Boccassi > Signed-off-by: Bruce Richardson > --- > =C2=A0config/rte_config.h | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/config/rte_config.h b/config/rte_config.h > index a8e479774..46775a841 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -20,6 +20,9 @@ > =C2=A0 > =C2=A0/****** library defines ********/ > =C2=A0 > +/* compat defines */ > +#define RTE_BUILD_SHARED_LIB > + > =C2=A0/* EAL defines */ > =C2=A0#define RTE_MAX_MEMSEG_LISTS 128 > =C2=A0#define RTE_MAX_MEMSEG_PER_LIST 8192 Tested-by: Luca Boccassi --=20 Kind regards, Luca Boccassi