* [dpdk-dev] [PATCH] compat: fix symbol version support with meson
@ 2018-08-30 17:07 Bruce Richardson
2018-08-30 17:31 ` Luca Boccassi
2018-09-17 8:18 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2018-08-30 17:07 UTC (permalink / raw)
To: bluca; +Cc: dev, Bruce Richardson
For meson builds, the define to enable the symbol version
macros in rte_compat.h was missing. This led to symbols being
omitted from shared objects. For example, checking rte_distributor.so
with objdump and comparing make and meson built versions:
$ objdump -T make-build/lib/librte_distributor.so | grep _flush
0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush
0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush
$ objdump -T meson-build/lib/librte_distributor.so | grep _flush
0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
Adding in the missing define fixes this.
Fixes: 5b9656b157d3 ("lib: build with meson")
Reported-by: Luca Boccassi <bluca@debian.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/rte_config.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/config/rte_config.h b/config/rte_config.h
index a8e479774..46775a841 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -20,6 +20,9 @@
/****** library defines ********/
+/* compat defines */
+#define RTE_BUILD_SHARED_LIB
+
/* EAL defines */
#define RTE_MAX_MEMSEG_LISTS 128
#define RTE_MAX_MEMSEG_PER_LIST 8192
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson
2018-08-30 17:07 [dpdk-dev] [PATCH] compat: fix symbol version support with meson Bruce Richardson
@ 2018-08-30 17:31 ` Luca Boccassi
2018-09-16 9:14 ` Thomas Monjalon
2018-09-17 8:18 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
1 sibling, 1 reply; 6+ messages in thread
From: Luca Boccassi @ 2018-08-30 17:31 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> For meson builds, the define to enable the symbol version
> macros in rte_compat.h was missing. This led to symbols being
> omitted from shared objects. For example, checking rte_distributor.so
> with objdump and comparing make and meson built versions:
>
> $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> 0000000000001b60 g DF .text 00000000000000a7
> (DPDK_2.0) rte_distributor_flush
> 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05
> rte_distributor_flush
> $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0
> rte_distributor_flush
>
> Adding in the missing define fixes this.
>
> Fixes: 5b9656b157d3 ("lib: build with meson")
>
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/rte_config.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config/rte_config.h b/config/rte_config.h
> index a8e479774..46775a841 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -20,6 +20,9 @@
>
> /****** library defines ********/
>
> +/* compat defines */
> +#define RTE_BUILD_SHARED_LIB
> +
> /* EAL defines */
> #define RTE_MAX_MEMSEG_LISTS 128
> #define RTE_MAX_MEMSEG_PER_LIST 8192
Tested-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson
2018-08-30 17:31 ` Luca Boccassi
@ 2018-09-16 9:14 ` Thomas Monjalon
2018-09-17 8:17 ` Bruce Richardson
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-09-16 9:14 UTC (permalink / raw)
To: Luca Boccassi, Bruce Richardson; +Cc: dev
30/08/2018 19:31, Luca Boccassi:
> On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> > For meson builds, the define to enable the symbol version
> > macros in rte_compat.h was missing. This led to symbols being
> > omitted from shared objects. For example, checking rte_distributor.so
> > with objdump and comparing make and meson built versions:
> >
> > $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> > 0000000000001b60 g DF .text 00000000000000a7
> > (DPDK_2.0) rte_distributor_flush
> > 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05
> > rte_distributor_flush
> > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> > 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0
> > rte_distributor_flush
> >
> > Adding in the missing define fixes this.
> >
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> >
> > Reported-by: Luca Boccassi <bluca@debian.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Tested-by: Luca Boccassi <bluca@debian.org>
Cc stable?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson
2018-09-16 9:14 ` Thomas Monjalon
@ 2018-09-17 8:17 ` Bruce Richardson
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2018-09-17 8:17 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Luca Boccassi, dev
On Sun, Sep 16, 2018 at 11:14:10AM +0200, Thomas Monjalon wrote:
> 30/08/2018 19:31, Luca Boccassi:
> > On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> > > For meson builds, the define to enable the symbol version
> > > macros in rte_compat.h was missing. This led to symbols being
> > > omitted from shared objects. For example, checking rte_distributor.so
> > > with objdump and comparing make and meson built versions:
> > >
> > > $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> > > 0000000000001b60 g DF .text 00000000000000a7
> > > (DPDK_2.0) rte_distributor_flush
> > > 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05
> > > rte_distributor_flush
> > > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> > > 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0
> > > rte_distributor_flush
> > >
> > > Adding in the missing define fixes this.
> > >
> > > Fixes: 5b9656b157d3 ("lib: build with meson")
> > >
> > > Reported-by: Luca Boccassi <bluca@debian.org>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Tested-by: Luca Boccassi <bluca@debian.org>
>
> Cc stable?
>
Yes, will add on a V2.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] compat: fix symbol version support with meson
2018-08-30 17:07 [dpdk-dev] [PATCH] compat: fix symbol version support with meson Bruce Richardson
2018-08-30 17:31 ` Luca Boccassi
@ 2018-09-17 8:18 ` Bruce Richardson
2018-09-17 8:42 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2018-09-17 8:18 UTC (permalink / raw)
To: thomas; +Cc: dev, bluca, Bruce Richardson, stable
For meson builds, the define to enable the symbol version
macros in rte_compat.h was missing. This led to symbols being
omitted from shared objects. For example, checking rte_distributor.so
with objdump and comparing make and meson built versions:
$ objdump -T make-build/lib/librte_distributor.so | grep _flush
0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush
0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush
$ objdump -T meson-build/lib/librte_distributor.so | grep _flush
0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
Adding in the missing define fixes this.
Fixes: 5b9656b157d3 ("lib: build with meson")
CC: stable@dpdk.org
Reported-by: Luca Boccassi <bluca@debian.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Tested-by: Luca Boccassi <bluca@debian.org>
---
config/rte_config.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/config/rte_config.h b/config/rte_config.h
index a8e479774..46775a841 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -20,6 +20,9 @@
/****** library defines ********/
+/* compat defines */
+#define RTE_BUILD_SHARED_LIB
+
/* EAL defines */
#define RTE_MAX_MEMSEG_LISTS 128
#define RTE_MAX_MEMSEG_PER_LIST 8192
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] compat: fix symbol version support with meson
2018-09-17 8:18 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
@ 2018-09-17 8:42 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-09-17 8:42 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, bluca, stable
17/09/2018 10:18, Bruce Richardson:
> For meson builds, the define to enable the symbol version
> macros in rte_compat.h was missing. This led to symbols being
> omitted from shared objects. For example, checking rte_distributor.so
> with objdump and comparing make and meson built versions:
>
> $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush
> 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush
> $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
>
> Adding in the missing define fixes this.
>
> Fixes: 5b9656b157d3 ("lib: build with meson")
>
> CC: stable@dpdk.org
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-17 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 17:07 [dpdk-dev] [PATCH] compat: fix symbol version support with meson Bruce Richardson
2018-08-30 17:31 ` Luca Boccassi
2018-09-16 9:14 ` Thomas Monjalon
2018-09-17 8:17 ` Bruce Richardson
2018-09-17 8:18 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2018-09-17 8:42 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).