From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id B5FE2231E for ; Fri, 31 Aug 2018 12:19:10 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id r1-v6so843938wmh.0 for ; Fri, 31 Aug 2018 03:19:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=k1+r2Wm+zYDYK7rfEW3UggPp2vCvv+5bII6NWwKpDWg=; b=JjGUwnRz9mAsw+23j4tImSJOnjVBlN4pLrnW+8l4PwX/QiX5pIUIzr4u0QhzMQBCCL +SpTYWj/TfRRJb4Oxl0Aa5SakLzCG1xV7zCm/e4kXyLL2v2ku3sBhxlWn1ds/6dyW00k 2uQIuuxkSUdc8Ya1ISMCauBEOFf41+M6kIN4EsjIqmvekSZXccBHD/OND0CXYvw1E1RM ZUwvYIK1ang2sOGGAc6BqKunXTiadal00K75l8DwsRgyjqgYLERjEBhfc9Sw4gS1GulP KnPPQo5lTXFmbDGg2w8GrQaW6SnZ58Ux8hjQg5qb7iWrCpWV4x9+CIbzEQeF5HDdopeK nYZw== X-Gm-Message-State: APzg51CaLFuKfb2giLcDmkDmPj+v7VJJE7FSdhl5+6LdXWfBjN0Tf7Ub 1POQlR+Wisp42T164G6goo4= X-Google-Smtp-Source: ANB0VdbFYGiFamtNrYb8dQyXTLOBkUDXU6TRQM/i5+9j5j5W1F2ptN71qfGDpgU/+C0GrIaW4DHysA== X-Received: by 2002:a1c:780c:: with SMTP id t12-v6mr4206325wmc.133.1535710750474; Fri, 31 Aug 2018 03:19:10 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id v1-v6sm6678133wrt.34.2018.08.31.03.19.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 03:19:09 -0700 (PDT) Message-ID: <1535710748.11823.23.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Fri, 31 Aug 2018 11:19:08 +0100 In-Reply-To: <20180831101520.GA19592@bricha3-MOBL.ger.corp.intel.com> References: <20180831092029.4887-1-bluca@debian.org> <20180831092029.4887-4-bluca@debian.org> <20180831101520.GA19592@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] build: install igb_uio kernel module when building with Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 10:19:10 -0000 On Fri, 2018-08-31 at 11:15 +0100, Bruce Richardson wrote: > On Fri, Aug 31, 2018 at 10:20:29AM +0100, Luca Boccassi wrote: > > Install in $kerneldir/../extra/dpdk. Usually $kerneldir should > > something > > like: /lib/modules/$kver/build, so this directory will match the > > default > > one used by legacy makefiles. > >=20 > > Fixes: a52f4574f798 ("igb_uio: build with meson") > >=20 > > Signed-off-by: Luca Boccassi > > --- > > =C2=A0kernel/linux/igb_uio/meson.build | 2 ++ > > =C2=A0meson_options.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 2 +- > > =C2=A02 files changed, 3 insertions(+), 1 deletion(-) > >=20 > > diff --git a/kernel/linux/igb_uio/meson.build > > b/kernel/linux/igb_uio/meson.build > > index 71ed2e7a85..f5a9d5ccf3 100644 > > --- a/kernel/linux/igb_uio/meson.build > > +++ b/kernel/linux/igb_uio/meson.build > > @@ -15,4 +15,6 @@ custom_target('igb_uio', > > =C2=A0 '/../../../lib/librte_eal/common/include', > > =C2=A0 'modules'], > > =C2=A0 depends: mkfile, > > + install: true, > > + install_dir: kernel_dir + '/../extra/dpdk', > > =C2=A0 build_by_default: get_option('enable_kmods')) > > diff --git a/meson_options.txt b/meson_options.txt > > index c843278587..f452986da3 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -7,7 +7,7 @@ option('examples', type: 'string', value: '', > > =C2=A0option('include_subdir_arch', type: 'string', value: '', > > =C2=A0 description: 'subdirectory where to install arch-dependent=20 > > headers') > > =C2=A0option('kernel_dir', type: 'string', value: '', > > - description: 'path to the kernel for building kernel > > modules') > > + description: 'path to the kernel for building kernel > > modules, they will be installed in > > $prefix/$kernel_dir/../extra/dpdk') >=20 > Will $prefix be used in the install path? I thought it would be > $DEST_DIR? Yeah it was meant as a pseudo-variable :-) --=20 Kind regards, Luca Boccassi