From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 9808F7D26 for ; Fri, 31 Aug 2018 16:10:50 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id s12-v6so5410544wmc.0 for ; Fri, 31 Aug 2018 07:10:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=BBhoWXdyJQVJurEQzSl45HNlnu9+wy2ajlcZQSJz4uo=; b=UVJMz+/nLjwwe5iUWhhnae/S9o1KC7QoWLWmCB9VfnhySzX6gnUiZg2sQ1I+hN43uM BGK/Du7BJS4td1TKiB3gQESJv3Z/EEQmIA4gcCs44DRwBiu5M3aZQT0ybCOsxA+6BwON XMa/MCkqSAKn2j/7TGZE/ykZ/ncoaO59IZEjSfK1Kr4Im60jZzcStx7a6q7PwWcftRfH zAnsHxS0Ia/P+HPYebLfq+AtRrMXinoBKzujBTMiM0MM6kgS/XfEm9gdMUWjWSSP5ajn 2pf9GI6tywTMeErAfL70gvxo4weulsgZXoLo6/W5MoNfr+a2m+8/9humR5dK8Fc6faKL AdFg== X-Gm-Message-State: APzg51D1KjApVbV2/W7Zgp2LfJcI1UE5nSaaQb7QQxwPG7iy7puhDI6Z es3dqsuvw3/qxCm0oT4/Qlg= X-Google-Smtp-Source: ANB0VdZ3YHG+FCfZgW5OB9Eq/jBfx/YWW6TIBM5oewnWcvU1+ISwBsU8nD46Dm54Pqx8wEwWeOBU7w== X-Received: by 2002:a1c:1203:: with SMTP id 3-v6mr5079655wms.46.1535724645594; Fri, 31 Aug 2018 07:10:45 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id c8-v6sm10944312wrp.33.2018.08.31.07.10.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 07:10:43 -0700 (PDT) Message-ID: <1535724642.11823.26.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , bruce.richardson@intel.com Cc: dev@dpdk.org Date: Fri, 31 Aug 2018 15:10:42 +0100 In-Reply-To: <20180831135132.14730-1-thomas@monjalon.net> References: <20180831135132.14730-1-thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: get version number from header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 14:10:50 -0000 On Fri, 2018-08-31 at 15:51 +0200, Thomas Monjalon wrote: > The header file rte_version.h should be the unique place > to define the version number. > The makefile command "showversion" makes it accessible, > and it is used to set the meson project version with an external > command. >=20 > Signed-off-by: Thomas Monjalon > --- >=20 > I don't know how to check easily the meson version number. > Please help in testing, thanks. >=20 > --- > =C2=A0meson.build | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/meson.build b/meson.build > index 84af32ece..b9d1030e7 100644 > --- a/meson.build > +++ b/meson.build > @@ -2,7 +2,7 @@ > =C2=A0# Copyright(c) 2017 Intel Corporation > =C2=A0 > =C2=A0project('DPDK', 'C', > - version: '18.11-rc0', > + version: run_command('make', > 'showversion').stdout().strip(), > =C2=A0 license: 'BSD', > =C2=A0 default_options: ['buildtype=3Drelease', > 'default_library=3Dstatic'], > =C2=A0 meson_version: '>=3D 0.41' Isn't the ultimate end goal to remove the makefiles? If so, shouldn't meson be independent? --=20 Kind regards, Luca Boccassi