DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nikhil Rao <nikhil.rao@intel.com>
To: jerin.jacob@caviumnetworks.com
Cc: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
	vipin.varghese@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] test/eventdev: remove eth Rx adapter vdev workaround
Date: Thu,  6 Sep 2018 14:41:43 +0530	[thread overview]
Message-ID: <1536225103-181590-2-git-send-email-nikhil.rao@intel.com> (raw)
In-Reply-To: <1536225103-181590-1-git-send-email-nikhil.rao@intel.com>

eth Rx adapter has been updated to support hotplugged
devices, devices created after adapter creation can now be
added to the adapter.

Update the adapter_multi_eth_add_del
test case to create the adapter as part of test setup
instead of creating it after creating vdevs.

Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
Cc: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 test/test/test_event_eth_rx_adapter.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 4cca77f..d6d137e 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -489,9 +489,6 @@ struct event_eth_rx_adapter_test_params {
 	err = init_ports(rte_eth_dev_count_total());
 	TEST_ASSERT(err == 0, "Port initialization failed err %d\n", err);
 
-	/* creating new instance for all newly added eth devices */
-	adapter_create();
-
 	/* eth_rx_adapter_queue_add for n ports */
 	port_index = 0;
 	for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
@@ -509,8 +506,6 @@ struct event_eth_rx_adapter_test_params {
 		TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 	}
 
-	adapter_free();
-
 	return TEST_SUCCESS;
 }
 
@@ -675,7 +670,8 @@ struct event_eth_rx_adapter_test_params {
 		TEST_CASE_ST(NULL, NULL, adapter_create_free),
 		TEST_CASE_ST(adapter_create, adapter_free,
 					adapter_queue_add_del),
-		TEST_CASE_ST(NULL, NULL, adapter_multi_eth_add_del),
+		TEST_CASE_ST(adapter_create, adapter_free,
+					adapter_multi_eth_add_del),
 		TEST_CASE_ST(adapter_create, adapter_free, adapter_start_stop),
 		TEST_CASE_ST(adapter_create, adapter_free, adapter_stats),
 		TEST_CASES_END() /**< NULL terminate unit test array */
-- 
1.8.3.1

  reply	other threads:[~2018-09-06  9:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06  9:11 [dpdk-dev] [PATCH 1/2] eventdev: fix eth Rx adapter hotplug incompatibility Nikhil Rao
2018-09-06  9:11 ` Nikhil Rao [this message]
2018-09-20  6:38   ` [dpdk-dev] [PATCH 2/2] test/eventdev: remove eth Rx adapter vdev workaround Jerin Jacob
2018-09-20  6:37 ` [dpdk-dev] [PATCH 1/2] eventdev: fix eth Rx adapter hotplug incompatibility Jerin Jacob
2018-09-23  8:31 ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536225103-181590-2-git-send-email-nikhil.rao@intel.com \
    --to=nikhil.rao@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=stable@dpdk.org \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).