From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D37D845AF3;
Wed, 9 Oct 2024 12:53:16 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A34BF4065D;
Wed, 9 Oct 2024 12:53:16 +0200 (CEST)
Received: from fout-a1-smtp.messagingengine.com
(fout-a1-smtp.messagingengine.com [103.168.172.144])
by mails.dpdk.org (Postfix) with ESMTP id 1C6BB4064C
for <dev@dpdk.org>; Wed, 9 Oct 2024 12:53:15 +0200 (CEST)
Received: from phl-compute-05.internal (phl-compute-05.phl.internal
[10.202.2.45])
by mailfout.phl.internal (Postfix) with ESMTP id 7C6FA13801CA;
Wed, 9 Oct 2024 06:53:14 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-05.internal (MEProxy); Wed, 09 Oct 2024 06:53:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm2; t=1728471194;
x=1728557594; bh=PQmSv7gZHH/mCiAS/pn5gOOjNmusNaOKcnYbmRnjz28=; b=
Ql6NgHEQUKe3Gda30awLcn9yT2IJQaMtPr2jLLCZhihcPlFuyg8zdvlcPCgnWi5H
VwJ9k8bert/qBfryL7IJkbasEqdealLXdqVO+bblVQHZ6SopVJ/Xmt0pKB5hWago
5OY4CH1fzDj2d6xUsKI8ivFtMRlcLVkHPDT89oo8KRh7MrED1qj6IgXu5VnYI57p
b9h/WuanQNyrTGKatyRgR6txOKgy7Ho2gvf7CaIgf/jFIrQv9S7Vgs5SAXi9CUIt
CcjvFiLJA4ox0BMLRnyNazAOid0TkkAvYuEfhI5QwYPB6wcduCimOqd0b9afKjo4
v6iBTIV2nH5pyhvB0Upu+w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728471194; x=
1728557594; bh=PQmSv7gZHH/mCiAS/pn5gOOjNmusNaOKcnYbmRnjz28=; b=p
8p3w+16Z0olz8AcPxWnBQp9FiGvYn41HKqjqVTRuxLHUGRP4aBd7fL2ZokK5SyJ7
ZMPPC1AJNiNo36zoxy+iS0WGpHVTF475ZJ0vkRyskr+ZOrZHJ4bcl4mD16YVb8aN
RcETjPRef2b+Opm09zFN9jFckME3u+W31GqlFNaVQd3xfZD2K0u8l/OK2Rk+xPDY
CNU67w6OU0Qf6zYpPRgjS8PyLae3eegNT5hjKM4kUKTHcEBmQCCmT+QmkKE8ciFI
7c4rOYRCkLnbYasREmm3R1DEgUvreKxCvkNn1DQxZ6Ic3AlBeNegC+LnKUACnjH+
7UmlUHwElEoTFTDUPTg1Q==
X-ME-Sender: <xms:mWAGZ9Ye3AxPykwjE6UQfg7GMGixP4KBo8SfodF_7xEwe89nsQ3g5A>
<xme:mWAGZ0aBq4YJf84VutdGWAyAyhwYtBEr9tI2wgHNqA67HC9rYjTayGmwVI-WQzWEF
ywzTiF8qmslR4t-Sw>
X-ME-Received: <xmr:mWAGZ_9GE0UdByp3Ke4BNR3zb6347q74AoGWjH3WOaPFA579EzMWKQ0ovFmnq0u9QJ1cFRky4tfB6RpKj8ib06ZJww>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeffedgfeehucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen
ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg
hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek
ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf
grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn
sggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrghkhh
hilhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopegrnhhoohgsjhesmhgrrhhvvghl
lhdrtghomhdprhgtphhtthhopehkthgvjhgrshhrvggvsehmrghrvhgvlhhlrdgtohhmpd
hrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtohepvhhvvghluhhmuhhr
ihesmhgrrhhvvghllhdrtghomh
X-ME-Proxy: <xmx:mmAGZ7rA9ZRKQuF0XhYZEIYVyxtUsVdmalFy0hfPVX4lvuzay_fiDg>
<xmx:mmAGZ4rvhWtBnurDJzvuIKMzYqUJmvkevvNIwGqWLI9t5u_GqMXEAw>
<xmx:mmAGZxSWWx0mPTrwaBV0LTlOmS2_f1m3HBk-N3u5YCEQMJyFt4F4XA>
<xmx:mmAGZwpw4u2QGwU0qGWbfZDubgkyn0H4eptYeKVC0fjT7dH7g1VJaw>
<xmx:mmAGZ9B06AHySu0lHZyyu9YWd7p8p1KJsgltySk507YNHzWHnaTJBEbT>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
9 Oct 2024 06:53:13 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>, Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>
Cc: dev@dpdk.org, Vidya Sagar Velumuri <vvelumuri@marvell.com>
Subject: Re: [PATCH 11/11] crypto/cnxk: add PMD API to get qp stats
Date: Wed, 09 Oct 2024 12:53:11 +0200
Message-ID: <15365280.tv2OnDr8pf@thomas>
In-Reply-To: <20240905074631.1462357-12-ktejasree@marvell.com>
References: <20240905074631.1462357-1-ktejasree@marvell.com>
<20240905074631.1462357-12-ktejasree@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
05/09/2024 09:46, Tejasree Kondoj:
> From: Anoob Joseph <anoobj@marvell.com>
>
> Add PMD API to get CPT LF(QP) stats.
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
> +struct rte_pmd_cnxk_crypto_qp_stats {
> + /** Packet counter of the packets that used CPT context cache and was encrypted */
> + uint64_t ctx_enc_pkts;
> + /** Byte counter of the packets that used CPT context cache and was encrypted */
> + uint64_t ctx_enc_bytes;
> + /** Packet counter of the packets that used CPT context cache and was decrypted */
> + uint64_t ctx_dec_pkts;
> + /** Byte counter of the packets that used CPT context cache and was decrypted */
> + uint64_t ctx_dec_bytes;
> +};
[...]
> --- a/drivers/crypto/cnxk/version.map
> +++ b/drivers/crypto/cnxk/version.map
> @@ -10,6 +10,7 @@ EXPERIMENTAL {
> rte_pmd_cnxk_crypto_cptr_get;
> rte_pmd_cnxk_crypto_cptr_read;
> rte_pmd_cnxk_crypto_cptr_write;
> + rte_pmd_cnxk_crypto_qp_stats_get;
I don't think it is a good idea.
You should introduce xstats in cryptodev, the same as in ethdev.