From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0057.outbound.protection.outlook.com [104.47.40.57]) by dpdk.org (Postfix) with ESMTP id 1C90810BD for ; Mon, 10 Sep 2018 08:14:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JS8BJJpTmStvnFIbxNdx1aqpe1pRUMIWOev+5zsat2o=; b=HzS6BKuyj4f6LF3c9yVH+6hYVEekNpgK/UvoiToYsY1TCCSmnCjUAJVuPP1nNNE73mQ6O0JcZ4Eq832u7XAbJRu+t2slE04KYxF0pkNtn+2wa2GAphmrbP5xNJlc3H8RPJIIcF5A7Md+hwXFeQAVO9BDz2cqcHUbZWvw0pTq8Ns= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.com (115.113.156.2) by BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Mon, 10 Sep 2018 06:14:41 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Akash Saxena Date: Mon, 10 Sep 2018 11:44:03 +0530 Message-Id: <1536560043-24807-1-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: MAXPR0101CA0050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::12) To BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1526a92e-cc32-4272-f9e9-08d616e4b381 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4897; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 3:gVlz3c+D+76JF2IzmI/88UB9vt75E2pMX8he4fO+uFUguPrGYcr4zflfzmBuQiOvvxWMFX97VraMkwuiCTarZ/EqZg/0Z4DymWweA1QOOmAx3+SzJvuZeRkNjPJeG79KCtNFINbp++oT37zUO4KIl5X8XqTPQqwqE6S9yUgQABGMSvXF6I0cz3HdsQ5OUQUVXfc1td4oJXuPNjcyaQoYvfdG0ij606PmUQQ4DG3dVHnomG92nQFKypY/TbrMXLre; 25:mHhM4z7lXzuJMsjNx2SqpBGH+0chLbGrqGY0J6nP9zR5JjREgVPt/BjlbknL6KTIrDfpOuSOIZWJausmK90HpTI0svRN7pBfSdfXE0sHRePQXuVdfHF+xam6WPKauGLZzbo8HO9qoYx/q8fHupm3yUho+PwrZOwdXj+HpAEWyOdVUgISNNdaDMGLGZeJ0V2VW3I0yY/8quSoZtvPKzMLKuDe4jDRUnNACABVciImoHxavH1TYfd/RRaL+JjUTCg/P18KoMJPVIVuCIFI3tmspZX9CUO2GuEkp9ZhK6IqUFBBXkbe6Uh8B/abSrNEsUIzw1YXMR1CiPhypQr63t/W1A==; 31:fk11Fwof5EKUWrPd2YquTfzXvGZRk5mTkZy45o95K+KBXvvt3aCLFz3LeC9vO+keKQUfVAhSID4Qp5oS5tESPMKI9cf/bRKWRv1lybWUj3PRKjeDQ9rj2tdu2bwvT5voTCKC/7Ly8EhodWBLhRTGu0cv2T/AnUIITbXs9OtC3QLgyrddyRDLYTOujGHia4bOEH6fgRVTKH0h3laFvRgs5hRs+1L6BMV+t1t+NGVovEA= X-MS-TrafficTypeDiagnostic: BN7PR07MB4897: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 20:j2Th5R7fzvbFRPP9K2KSKpKWGhLz+BjfNqTbvrHPg505efuocUqvV6nDbAGKM2Yyh/RlYZ9lgoffNJkkYXeET18lAFhQ/LTg5IKSmHcYChlF3k+C+a3NPWf3yAtbIj9914vLgAvu3vigCXjE+iH+c84SyyiWerX4xk1Svm90q1ldAbtOZLuhMnarJM4riQDwp/z7PamcKU83aj0hkvgwQHyQyaetQzPm5JSohe4qHH2RxrJjDTjCDWpQFUjKBDm2RLB3BhgX3rGDtcPUHQFUNNl9ILk6eY8A//2sbJwzzLwMgG9X0SiuNLWtIATrkLUDT711mCv9KYeELs4QDXfK6VSuwdhaYJRAhqvqJMLJEZQucAWfnyhi4TixtLexfM2UTbEJx0s27sDtCoBXlPV3+dGmkbZZwF5MmvUCZRDnHYOYZvDqzHARSNp/iWe9sHBmTagm8N7VnFDMOnbZfP/qakl9cQNuHARZ+LNW5ilrki+GqdRz+3v8V3kcCrrliUC/uu5sbrHX6cF83UZDyo9+iA6p500c37ffT+e/VZ/kGwkB7CSpAsgdiJvA1FGUzUqQsTxc9fAMO6mYxWxHLem9Vak6w+g9qMbRYjEvgkX9yxM=; 4:Cps3Iy29F72ahhG6CuZAkeIhU5xH+V3mhOi/JPuq1ZG3NtHpnQ9eANdrHosNL+evg2nVmsxQq7c+lZe92VUW/edda1U3oqbzcKXJFVlXRQCU3G70aArCLzwTSqQTptP9ikmkZE46iDm8zhN5QLjVLqr1psiiJabd/iPNsPvj3O6d8ww/jS0x4M/UYllps9YygbD4y8M36Z9CZQf72O6rZjIMkyhEDClYqBWgTXRICpTdA4VX9D3+UJcILKvXuEKBlWp79rFga8Tvo7rp2JsJ1A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699050); SRVR:BN7PR07MB4897; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4897; X-Forefront-PRVS: 07915F544A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(136003)(396003)(376002)(189003)(199004)(81156014)(476003)(8936002)(2616005)(956004)(6486002)(486006)(81166006)(8676002)(50226002)(68736007)(66066001)(305945005)(7736002)(1857600001)(105586002)(2906002)(3846002)(97736004)(6512007)(47776003)(44832011)(5660300001)(106356001)(6116002)(186003)(16526019)(478600001)(72206003)(42882007)(36756003)(26005)(51416003)(52116002)(316002)(16586007)(4326008)(50466002)(48376002)(53936002)(110136005)(54906003)(6666003)(25786009)(107886003)(386003)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4897; H:ajoseph83.caveonetworks.com.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4897; 23:RwzUfknvVPzNKoBNONmpotl3Zqs5eAwflfMFHjV1V?= =?us-ascii?Q?VFbDzkH18iaGqucQ+vMW57anUFRszb+j9xvsBvHiVF6ClfrGBwUTcrqcBsvL?= =?us-ascii?Q?Cd09RTlEq0Lm68/X+mjGW8gSpYTvrBVBZ9ZNX2caz2Atk12R34og7CZQHnnB?= =?us-ascii?Q?tf0xHV1+/xvanPo724q3B4lnfHAMoLix48GiwU2UiQy2YYwyMZzx4PDftPcs?= =?us-ascii?Q?2RCgHxt91p8MNzwIbOKZnHmtyVE4eO6FamsxN3xf1MFnyMYcK2lxWBVJ76nK?= =?us-ascii?Q?Zl9WaSkd2fzaFmfCmD/RHqF9MmU/jcq6Q021zjXKBebwWrJvX7FbpOli0jYv?= =?us-ascii?Q?vjsWuTFGMCy7QvzY4DkazL0u0Ycm4hrHrsPoOpAw/dBJ7rIfpVu7ctzTh3/O?= =?us-ascii?Q?jIsPdtYhF1GZT6kWGWMybCXq3+/BpF6jJT1GrZpXLd+ic4pqFbiV+NCJIL2J?= =?us-ascii?Q?Eq1VtApmi30p9ZAXh6jp3xZo1Fnja7rcQCmx4VlRxMveuDzieFekz3rAMfii?= =?us-ascii?Q?qpRmxIsex19l43WqthqW/UBgRwONsXvIgNCeZyRuwJyvSjx810Us/Vx4VGZZ?= =?us-ascii?Q?/itgNgSlcQM5LDos7XKTc1FSbwv826zDnhNq7fKWtZgkPkJ1s37DudillYHL?= =?us-ascii?Q?yvxB3Ra+7fVT7EuscR34CEZeVJenh7k7A30K2DiyuU5lLbR95EeE1eRcxP+N?= =?us-ascii?Q?suqhaJRoInca803PTn3E4haLsVgKCdkBKSaIvhfrK68y2aNqDxnVlCgkcTHc?= =?us-ascii?Q?W/ZJArvxwMYr/G8FvXynaWPy79MsePOChIoVeMHxx4UDylKFvhAa/32Mj6A4?= =?us-ascii?Q?AwJ7xDF0BU8SZJlqh7ihmFYSEbQ4P76yi/GtUM4tyf/7mTzyivXK6u3QhJzI?= =?us-ascii?Q?31DZdXyOdfceWlH7E/QbcQi66eQwylF6T3VzxiLYEiURKIG4LP3P1twk0e5F?= =?us-ascii?Q?KUDdz+QB/7UySCxNxM55OlvhRlAaVe5FtlGG3bAOtpbUWVohlKGpFWOLSlpE?= =?us-ascii?Q?2vO69tli4EZKTgxyypsM7yPJ2giiKnpNi4m6Za7W6oR1tpjRj9dSIaLz8IQ7?= =?us-ascii?Q?QP0Bt1ynOqI6CsWSf8gY8G5vBM5Yo8ZmGxa8R64PZNUb4h5rUPbs4sxkBfOl?= =?us-ascii?Q?+F20ejMNPJ6KzrVkBaipGzWeXxQ3enssvzXrCpOJn+HQK5j1HvYph1RC+467?= =?us-ascii?Q?iixctC0eFITYDiBqmXeU6N2t7anz9W8Bb9UZDOVcWvEmQqwkDrICLvizA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Antispam-Message-Info: PUA+xuyGbpUa8yaTbr4HUkEP3Txqog1jiJHJdzqtJU3XiwIdApp4N2LgbOOw83g3PNcXhJxv183xvDozbC+a/Ewvkc0BJyIl7hxkP7MgQKzDXsSxaRGY45Rs4JA3BtvemxtD8teucL7ef5UERcUUn8Ei9rpPQ3KEWCyytNa00bTrD9T8KYzMg1j0DoMy/LY0PoYXcHQfAkJSfqV6GptatTiQVUe2UHyYTEfTUGlW1Ay2DTNIbPN3ZGERgSIZgqa8PZOdHskgJJ3RK0E6pGMaNRr9uiHX1+EPVWDvUheQ245pXy2Y1oIle15B6YlXZszrNI2m+Huuw61gVq8eZXG7wONREXu7kBCRYCvZprCiwLk= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 6:YlRtBRDDKuJF0vHhgvR7JTfAlcGCYeEzXTAKZ0bYgUtvCgASHAAOujx2mOmkCVthCQOMPCAngvYO8anHFEJqh+JC3WLkfs996uOI1UPLeY6krbG8fZ1Acsa5F99rUhfSoDVnSl44Fbj9o9AjtMsKm3uwZ4ha4f699CB+KnmMvQ2QhrQJu2AMZz0mPpbes3VzobKQdNG42AZRaXWelq/EVPxRMRxB63DqDPoNk0EgpXbdjvK4x7mtpL1Je/jY7b/KSJyA6gwevf01xr20qdOsbFGMwu/L9uwwNv6by4qRwUig5KuwLh+nRoXa6UsvGkK+OC6QeYnSrhBRJMFi+GB4Q/9SEWmu7IJWwxCYqUgWTt1DZx1hqJBHSvzpe4WOyeGt63v6L+kN8EUztzpOq53v0Q+ZuKZoRkgz6fRKMfJAQrLB1291Npmcb5A8yFjA+J3F/HWHIldZYURlmJq8ekt5Hw==; 5:q9HYFoLlI5Qfwawnii0qBvZqNLBW73XNR1tw7QSqyQom3S/z/Zu1JhAUGQYmlmcSQzalrSBT69RsilAfr4l1XUf4LvuXF1v0OXRv3ibAXF3z+T9Rum0NGWNS0J11HQ97+Lm8c+OBOeQ8MHltg9JAyhyFp2UaytLLZhmGGLmv+uw=; 7:qVDpccjTCv6Yjr1XUMF1R9Zj4kZk36Qatqw2I1ITUUFe09LPVMqPCKKXFbBKI55ZEw4tfx6FULX/MEjFjMbqLXbEN4+zeHVC5fRnc95crMy4vx1R9O+TpOEWJyNyAk9KiB1OQ4KcNMmVRQ2zzT54muiFAInroMgrLXh3UCqsMPvhGa2QbfhQUBwkWIQQoOglhni/EbCksRZo4TJmdV2gUGo/eBxd1uhs9Za+2ERBQKPBqMOw2Nl0jwKxXdvv+5kp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2018 06:14:41.0347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1526a92e-cc32-4272-f9e9-08d616e4b381 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4897 Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix double allocation of memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 06:14:46 -0000 The field, 'cipher_iv.data' is allocated twice when cipher is not null. Ideally the allocation should depend only on the field 'cperf_options.cipher_iv_sz'. This will make sure this code path gets valid for ciphers which doesn't require IV. Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session") Signed-off-by: Akash Saxena Signed-off-by: Anoob Joseph --- app/test-crypto-perf/cperf_test_vectors.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c index 907a995..a6c2350 100644 --- a/app/test-crypto-perf/cperf_test_vectors.c +++ b/app/test-crypto-perf/cperf_test_vectors.c @@ -419,13 +419,19 @@ cperf_test_vector_get_dummy(struct cperf_options *options) t_vec->cipher_key.length = 0; t_vec->ciphertext.data = plaintext; t_vec->cipher_key.data = NULL; - t_vec->cipher_iv.data = NULL; } else { t_vec->cipher_key.length = options->cipher_key_sz; t_vec->ciphertext.data = ciphertext; t_vec->cipher_key.data = cipher_key; - t_vec->cipher_iv.data = rte_malloc(NULL, options->cipher_iv_sz, - 16); + } + + /* Init IV data ptr */ + t_vc->cipher_iv.data = NULL; + + if (options->cipher_iv_sz != 0) { + /* Set IV parameters */ + t_vec->cipher_iv.data = rte_malloc(NULL, + options->cipher_iv_sz, 16); if (t_vec->cipher_iv.data == NULL) { rte_free(t_vec); return NULL; @@ -433,17 +439,7 @@ cperf_test_vector_get_dummy(struct cperf_options *options) memcpy(t_vec->cipher_iv.data, iv, options->cipher_iv_sz); } t_vec->ciphertext.length = options->max_buffer_size; - - /* Set IV parameters */ - t_vec->cipher_iv.data = rte_malloc(NULL, options->cipher_iv_sz, - 16); - if (options->cipher_iv_sz && t_vec->cipher_iv.data == NULL) { - rte_free(t_vec); - return NULL; - } - memcpy(t_vec->cipher_iv.data, iv, options->cipher_iv_sz); t_vec->cipher_iv.length = options->cipher_iv_sz; - t_vec->data.cipher_offset = 0; t_vec->data.cipher_length = options->max_buffer_size; -- 2.7.4