From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name
Date: Tue, 11 Sep 2018 17:05:15 +0100 [thread overview]
Message-ID: <1536681915.10952.23.camel@debian.org> (raw)
In-Reply-To: <20180911140614.GA22976@bricha3-MOBL.ger.corp.intel.com>
On Tue, 2018-09-11 at 15:06 +0100, Bruce Richardson wrote:
> On Tue, Sep 11, 2018 at 02:41:36PM +0100, Luca Boccassi wrote:
> > On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote:
> > > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote:
> > > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote:
> > > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi
> > > > > wrote:
> > > > > > The library is called librte_pmd_lio, so rename the map
> > > > > > file
> > > > > > and
> > > > > > set
> > > > > > the name in the meson file so that the built library names
> > > > > > with
> > > > > > meson
> > > > > > and legacy makefiles are the same
> > > > > >
> > > > > > Fixes: bad475c03fee ("net/liquidio: add to meson build")
> > > > > > Cc: stable@dpdk.org
> > > > > >
> > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > >
> > > > > Rather than doing this renaming, can we instead add a symlink
> > > > > in
> > > > > the
> > > > > install phase to map the old name to the new one? I'd like to
> > > > > see
> > > > > the
> > > > > consistency of directory name, map filename and driver name
> > > > > enforced
> > > > > strictly in the build system. Having exceptions is a pain.
> > > > >
> > > > > /Bruce
> > > >
> > > > We could, but the pain gets shifted on packagers then - what
> > > > about
> > > > renaming the directory entirely to net/lio?
> > >
> > > For packagers, what sort of ABI compatibility guarantees do you
> > > try
> > > and
> > > keep between releases. Is this something that just needs a one-
> > > release ABI
> > > announcement, as with other ABI changes?
> > >
> > > /Bruce
> >
> > Currently in Debian/Ubuntu we are using the ABI override (because
> > of
> > the sticky ABI breakage issue) so the filenames and package names
> > are
> > different on every release anyway.
> >
> > So in theory we could change the name of the libs and packages, but
> > what I'm mostly worried about is keeping consistency and some level
> > of
> > compatibility between old and new build systems, isn't that an
> > issue?
> >
>
> It's a good question, and I suspect everyone will have their own
> opinion.
>
> Personally, I take the view that moving build system involves quite a
> number of changes anyway, so we should take the opportunity to clean
> up a
> few other things at the same time. This is why I'm so keep on trying
> to
> keep everything consistent as far as possible throughout the system
> and not
> put in special cases. For many of these a) if we put in lots of name
> overrides now we'll probably never get rid of them, and b) it's more
> likely
> that future drivers will adopt the same technique to have different
> naming
> of drivers and directories.
>
> However, if keeping sonames consistent is a major concern, then
> perhaps we
> should look to rename some directories, like you suggested before.
>
> /Bruce
Actually I tend to agree, it would be better to make the libraries
consistent, so I'm fine with having to deal with it once in packaging.
I'll send a v2 without most of the renames.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-09-11 16:05 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 20:04 [dpdk-dev] [PATCH 00/15] rename PMDs map files to match library name and add Meson files Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 01/15] build: add Meson file for tap PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 02/15] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 03/15] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 04/15] build: add Meson files for avf PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 05/15] build: add Meson files for qede PMD Luca Boccassi
2018-09-11 9:16 ` Shaikh, Shahed
2018-09-10 20:04 ` [dpdk-dev] [PATCH 06/15] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name Luca Boccassi
2018-09-11 13:06 ` Bruce Richardson
2018-09-11 13:09 ` Luca Boccassi
2018-09-11 13:30 ` Bruce Richardson
2018-09-11 13:38 ` Luca Boccassi
2018-09-11 13:32 ` Bruce Richardson
2018-09-11 13:41 ` Luca Boccassi
2018-09-11 14:06 ` Bruce Richardson
2018-09-11 16:05 ` Luca Boccassi [this message]
2018-09-10 20:04 ` [dpdk-dev] [PATCH 08/15] event/opdl: rename map file to match library name Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 09/15] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 10/15] net/thunderx: rename version map after library file name Luca Boccassi
2018-09-11 13:09 ` Bruce Richardson
2018-09-10 20:04 ` [dpdk-dev] [PATCH 11/15] net/sfc: " Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 12/15] event/octeontx: " Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 13/15] compress/octeontx: " Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 14/15] net/vmxnet3: " Luca Boccassi
2018-09-13 21:44 ` Yong Wang
2018-09-14 7:46 ` Thomas Monjalon
2018-09-10 20:04 ` [dpdk-dev] [PATCH 15/15] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-11 16:08 ` [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD Luca Boccassi
2018-09-11 16:08 ` [dpdk-dev] [PATCH v2 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-11 16:08 ` [dpdk-dev] [PATCH v2 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-11 16:08 ` [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-13 13:24 ` Bruce Richardson
2018-09-13 13:27 ` Luca Boccassi
2018-09-13 14:48 ` Bruce Richardson
2018-09-11 16:08 ` [dpdk-dev] [PATCH v2 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-11 16:09 ` [dpdk-dev] [PATCH v2 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-11 16:09 ` [dpdk-dev] [PATCH v2 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-11 16:09 ` [dpdk-dev] [PATCH v2 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-11 16:09 ` [dpdk-dev] [PATCH v2 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-13 13:11 ` [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD Bruce Richardson
2018-09-13 13:28 ` Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 " Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-13 14:49 ` Bruce Richardson
2018-09-13 16:16 ` Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-13 16:15 ` [dpdk-dev] [PATCH v4 1/9] build: add Meson file for TAP PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-13 16:16 ` [dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-18 15:00 ` Luca Boccassi
2018-09-18 15:20 ` Bruce Richardson
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 1/9] build: add Meson file for TAP PMD Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-18 20:48 ` Thomas Monjalon
2018-09-19 8:31 ` Bruce Richardson
2018-09-19 8:42 ` Thomas Monjalon
2018-09-19 9:45 ` Bruce Richardson
2018-09-19 10:08 ` Bruce Richardson
2018-09-19 10:15 ` Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-18 20:54 ` [dpdk-dev] [PATCH v5 1/9] build: add Meson file for TAP PMD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536681915.10952.23.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).