From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: Marcelo Ricardo Leitner <mleitner@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
christian.ehrhardt@canonical.com
Subject: Re: [dpdk-dev] Change in binary name w/ meson build
Date: Wed, 12 Sep 2018 10:34:42 +0100 [thread overview]
Message-ID: <1536744882.10952.38.camel@debian.org> (raw)
In-Reply-To: <20180912093021.GA15632@bricha3-MOBL.ger.corp.intel.com>
On Wed, 2018-09-12 at 10:30 +0100, Bruce Richardson wrote:
> On Wed, Sep 12, 2018 at 06:21:06AM +0000, Shahaf Shuler wrote:
> > Friday, September 7, 2018 6:24 PM, Bruce Richardson:
> > > Subject: Re: [dpdk-dev] Change in binary name w/ meson build
> > >
> > > On Fri, Sep 07, 2018 at 03:13:43PM +0100, Bruce Richardson wrote:
> > > > On Wed, Sep 05, 2018 at 11:52:10AM +0000, Shahaf Shuler wrote:
> > > > > Hi Bruce,
> > > > >
> > > > >
> > > > > Playing w/ meson build I got to know that the binary name
> > > > > for testpmd
> > > > > got changed to dpdk-testpmd.
> > > > >
> > > > >
> > > > > Not sure if it was discussed or not before, but such
> > > > > change will affect
> > > > > all the automation used to run testpmd w/ the old build
> > > > > system.
> > > > >
> > > > >
> > > > > What is the reason for the change in the name?
> > > >
> > > > The primary driver was that the autotest binary could not be
> > > > called "test"
> > > > any more, since that is a reserved name. When appending a dpdk
> > > > prefix
> > > > to the test binary, I felt for consistency that other binaries
> > > > should
> > > > have a dpdk prefix too, to indicate that they come from DPDK.
> > > > If this
> > > > is a problem, we can remove the prefix from the binaries easily
> > > > enough.
> > > >
> > >
> > > Also to point out that when building with meson the scripting is
> > > going to have
> > > to change anyway, right. The actual build commands are different,
> > > the
> > > configuration commands are different, and the directories the
> > > resulting
> > > binaries are placed in are different too. Therefore, I'd like to
> > > keep the name
> > > prefixes if possible, since for automated tooling on DPDK there
> > > are going to
> > > have to be lots of other changes anyway.
> > >
> > > For packagers, the rename I understand could be problematic, but
> > > that could
> > > probably be solved by symlinks in the install phase.
> >
> > I am fine w/ the testpmd -> dpdk-testpmd change as it is more
> > correct to put it explicitly under the dpdk namespace.
> > I was raising this point because I am not sure it was explicitly
> > mentioned on the release notes and was hoping to get feedback also
> > from the people who build dpdk for distro
> >
>
> Agreed, I should have got wider feedback for this change at the time,
> but
> it's not to late to fix if it is problematic, I think. I too like
> having
> the namespacing, though.
>
> /Bruce
I can ship backward-compatibility symlinks easily for binary programs
in Debian/Ubuntu (unlike for libraries where it's a bit more
difficult), so personally I'm OK with namespacing things.
Christian?
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2018-09-12 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 11:52 Shahaf Shuler
2018-09-07 14:13 ` Bruce Richardson
2018-09-07 15:24 ` Bruce Richardson
2018-09-12 6:21 ` Shahaf Shuler
2018-09-12 9:30 ` Bruce Richardson
2018-09-12 9:34 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536744882.10952.38.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=mleitner@redhat.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).