From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 77EBC5B12; Wed, 19 Sep 2018 18:07:01 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id y139-v6so6836368wmc.2; Wed, 19 Sep 2018 09:07:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=ZBhPiIn2v+R+VLGY25mtOG71uUQnfV2yg3Lwg1lBV6s=; b=sNFUNq7chYqdMWyumA55Qfh5T95OSGQvEyq27M04I9XZS0WQda6vsQlwUNw34aDmRV qibmIicl5ATt7BzzR0p/weoLzHHUeYkdVnFcIlJmmtuUb6GFteFB77VHaUykPylRdmoM BF2+erHj3QMAjwna16LRhPy6J1Sb6ojECNndx+CuB1U0ZXKU257v9iYhe5gR2ndhYMu0 7qAISA1wz6aTMc1cSaYRPuXrdjQ7zVMrwIOWd6wI7BncMEC8MLRyIl0/+U4sSw+Nmefx exClsAtlox0kskO5r3sZ2lCQq/UiAPQPFe9T7N7GJNmwd7E5xy7sQ0L1tu7CQn+Sc9Lx G2vg== X-Gm-Message-State: APzg51CHqkO7NPDMiEQfRf4+AYP+6SWLYQjnDTe64Vlb+7fhaqWv727O 9ZCc4FyZ5b5XpYcav3EJ8nibETMcmYk= X-Google-Smtp-Source: ANB0VdYNz2yOwtDVgf76LEs9REqt5+xqE9w9O25XBn6P2m+L+CETm6z5pJpTZXCghbzu/Wv4VxoeLA== X-Received: by 2002:a1c:9ac9:: with SMTP id c192-v6mr3674566wme.47.1537373220965; Wed, 19 Sep 2018 09:07:00 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id u65-v6sm7686082wmd.31.2018.09.19.09.06.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Sep 2018 09:07:00 -0700 (PDT) Message-ID: <1537373219.10481.26.camel@debian.org> From: Luca Boccassi To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Cc: declan.doherty@intel.com, matan@mellanox.com, ehkinzie@gmail.com, Chas Williams , stable@dpdk.org Date: Wed, 19 Sep 2018 17:06:59 +0100 In-Reply-To: <20180919154825.5183-1-3chas3@gmail.com> References: <20180919154825.5183-1-3chas3@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: ensure fairness among slaves X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 16:07:01 -0000 On Wed, 2018-09-19 at 11:48 -0400, Chas Williams wrote: > From: Chas Williams >=20 > Some PMDs, especially ones with vector receives, require a minimum > number > of receive buffers in order to receive any packets.=C2=A0=C2=A0If the fir= st > slave > read leaves less than this number available, a read from the next > slave > may return 0 implying that the slave doesn't have any packets which > results in skipping over that slave as the next active slave. >=20 > To fix this, implement round robin for the slaves during receive that > is only advanced to the next slave at the end of each receive burst. > This should also provide some additional fairness in processing in > bond_ethdev_rx_burst as well. >=20 > Fixes: 2efb58cbab6e ("bond: new link bonding library") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chas Williams > --- > =C2=A0drivers/net/bonding/rte_eth_bond_pmd.c | 50 ++++++++++++++++++++++ > ------------ > =C2=A01 file changed, 32 insertions(+), 18 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi