From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 126E2A04AD; Fri, 1 May 2020 15:12:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69DB61D73B; Fri, 1 May 2020 15:12:12 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0DA1B1D735 for ; Fri, 1 May 2020 15:12:11 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 52EFE600FE; Fri, 1 May 2020 13:12:10 +0000 (UTC) Received: from us4-mdac16-45.ut7.mdlocal (unknown [10.7.64.27]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 51862200A4; Fri, 1 May 2020 13:12:10 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.38]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9E39A22006A; Fri, 1 May 2020 13:12:09 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 1FCB880005E; Fri, 1 May 2020 13:12:09 +0000 (UTC) Received: from [127.0.0.27] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 May 2020 14:11:59 +0100 To: Thomas Monjalon , , , , , , , References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> <20200427095737.11082-2-i.dyukov@samsung.com> From: Andrew Rybchenko Message-ID: <153739f3-6d57-60b5-cddb-6812ded0dbba@solarflare.com> Date: Fri, 1 May 2020 16:10:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200427095737.11082-2-i.dyukov@samsung.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25388.003 X-TM-AS-Result: No-1.841300-8.000000-10 X-TMASE-MatchedRID: cgbqQT5W8hfmLzc6AOD8DfHkpkyUphL96VTG9cZxEjJpsnGGIgWMmXds hTxl+9lVRTpdHYygurSFQ/stU/BE4N1JRbW+TjdxcI7vRACwF0JteYiRfHhOq6cxvibtoCq3bPW TB1ibv7TDlYWx9GKnI2wZylhWNts+rtKweE8yi76oNROcemDX/f1oeWeSGYUWmyiLZetSf8kir3 kOMJmHTBQabjOuIvShC24oEZ6SpSmcfuxsiY4QFPHvBa0fhJFDZKCADawj7blQXm8GG07SaK1rv JEKzldOXeHC3SKABMwobvy9vYiLhOVCwMKA8X7iAwPqhYszkXapW8JXwJBqXY+AINsBjc/u1Ufw uic5JbL9LYDTmJ61B7ZYo/NVyiDhH8FerAT0dJY= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.841300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25388.003 X-MDID: 1588338730-5bX--_b6zq1t Subject: Re: [dpdk-dev] [PATCH v1 1/6] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/20 12:57 PM, Ivan Dyukov wrote: > From: Thomas Monjalon > > When querying the link informations, the link status is > a mandatory major information. > Other boolean values are supposed to be accurate: > - duplex mode (half/full) > - negotiation (auto/fixed) > > This API update is making explicit that the link speed information > is optional. > The value ETH_SPEED_NUM_NONE (0) was already part of the API. > The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover > two different cases: > - speed is not known by the driver > - device is virtual > > Suggested-by: Morten Brørup > Suggested-by: Benoit Ganne > Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko