DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nikhil Rao <nikhil.rao@intel.com>
To: jerin.jacob@caviumnetworks.com
Cc: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
	vipin.varghese@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
Date: Tue, 25 Sep 2018 12:49:04 +0530	[thread overview]
Message-ID: <1537859945-16759-1-git-send-email-nikhil.rao@intel.com> (raw)
In-Reply-To: <1536149012-47081-1-git-send-email-nikhil.rao@intel.com>

skeleton PMD does not support
RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
implicit_release_disable so make the Rx queue_id = -1 and
initialize the event port configuration to zero.

Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
CC: stable@dpdk.org

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 test/test/test_event_eth_rx_adapter.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

v2:
* include patch to fix Rx adapter intr autotest as it is
  dependent on the first patch in this series.

v3:
* use memset to initialize structure in place of assignment.

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index d6d137e..080ff04 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -312,6 +312,8 @@ struct event_eth_rx_adapter_test_params {
 	struct rte_event_dev_info dev_info;
 	struct rte_event_port_conf rx_p_conf;
 
+	memset(&rx_p_conf, 0, sizeof(rx_p_conf));
+
 	err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
 	TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
@@ -493,7 +495,7 @@ struct event_eth_rx_adapter_test_params {
 	port_index = 0;
 	for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
 		err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
-				port_index, 0,
+				port_index, -1,
 				&queue_config);
 		TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 	}
@@ -502,7 +504,7 @@ struct event_eth_rx_adapter_test_params {
 	port_index = 0;
 	for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
 		err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
-				port_index, 0);
+				port_index, -1);
 		TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 	}
 
-- 
1.8.3.1

  parent reply	other threads:[~2018-09-25  7:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 12:03 [dpdk-dev] [PATCH] " Nikhil Rao
2018-09-05 13:51 ` [dpdk-dev] [PATCH v2 1/2] " Nikhil Rao
2018-09-05 13:51   ` [dpdk-dev] [PATCH v2 2/2] test/event: fix Rx adapter intr " Nikhil Rao
2018-09-10 13:44   ` [dpdk-dev] [PATCH v2 1/2] test/event: fix eth Rx adapter " Jerin Jacob
2018-09-25  7:19 ` Nikhil Rao [this message]
2018-09-25  7:19   ` [dpdk-dev] [PATCH v3 2/2] test/event: fix Rx adapter intr " Nikhil Rao
2018-09-29 12:00     ` Jerin Jacob
2018-09-29 11:59   ` [dpdk-dev] [PATCH v3 1/2] test/event: fix eth Rx adapter " Jerin Jacob
2018-10-01 10:09   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1537859945-16759-1-git-send-email-nikhil.rao@intel.com \
    --to=nikhil.rao@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=stable@dpdk.org \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).