From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 918012BF4 for ; Wed, 26 Sep 2018 12:18:13 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id l10-v6so3249372wrp.3 for ; Wed, 26 Sep 2018 03:18:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=RgcHxUJ5GHeiO85vuzUbIYTbthgUrchkJq9P1bDtHRA=; b=Z/PmFCppqA4LQDCNRw847pXqsYbcYqNV1vrBWqQm+L+ny1xpuuvs5p0MGu9bd7yAZ2 yuZHytztO4uD030dnJz89AMRbn2bgQQ9nAzKMDzYsqVJJOF9GDZxhHEIOGRECvMBGzmj Vvwru7TKlEfsY75szkGov8pCKY3mjwFQgE//Xk736z62zPyqmFjCU0klQq5Q6uB38yzL ushfC8Xe5zDNiSNL2F7hojp3Br9RFu4P/2P0YLzTajsMsd2YwysU/fMSPRZjDb4x6+YP ZN/k2hFBoB4F/KuDnwRfA/O2fuP880MZ3101U6CqXvFJcZehZC1Y3jMKsbWwIQEXzqjE /c4A== X-Gm-Message-State: ABuFfogQPZYjTTsAIeh/Xs8nAAALWHVKo0f3xSCeRKgMPHK6O/22TGrD Xf0Y3IQePUiplR5DnTVnaUQ= X-Google-Smtp-Source: ACcGV61tJsKY55+c6e8xcxPufLYDWLIjmVXRaUPmZlpDUKo2Pw/CAVGAKmH1hdKVL6IQN0jLV+shlg== X-Received: by 2002:a05:6000:108:: with SMTP id o8mr4415293wrx.196.1537957093171; Wed, 26 Sep 2018 03:18:13 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:489f:80a9:5d59:c6bd]) by smtp.gmail.com with ESMTPSA id s10-v6sm4285844wrw.35.2018.09.26.03.18.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Sep 2018 03:18:12 -0700 (PDT) Message-ID: <1537957091.8363.1.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Wed, 26 Sep 2018 11:18:11 +0100 In-Reply-To: <20180926091536.61370-1-bruce.richardson@intel.com> References: <20180926091536.61370-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: set RTE_ARCH_64 based on pointer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 10:18:13 -0000 On Wed, 2018-09-26 at 10:15 +0100, Bruce Richardson wrote: > Rather than relying on the target machine architecture, use the > size of a pointer from the compiler to determine if we are 64-bits > or not. This allows correct behaviour when you pass -m32 as a compile > option. It also allows us to use this value repeatedly throughout the > repo rather than continually testing for the sizeof(void*). >=20 > Signed-off-by: Bruce Richardson > --- > =C2=A0config/arm/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 3 +-- > =C2=A0config/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| 5 ++++- > =C2=A0config/ppc_64/meson.build=C2=A0=C2=A0=C2=A0| 4 +++- > =C2=A0config/x86/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 3 +-- > =C2=A0drivers/net/sfc/meson.build | 2 +- > =C2=A0lib/librte_bpf/meson.build=C2=A0=C2=A0| 2 +- > =C2=A0lib/librte_kni/meson.build=C2=A0=C2=A0| 2 +- > =C2=A07 files changed, 12 insertions(+), 9 deletions(-) Tested-by: Luca Boccassi Build-tested on ppc64 and arm64 native Debian sid hosts. --=20 Kind regards, Luca Boccassi