From: Luca Boccassi <bluca@debian.org>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, stable@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set
Date: Wed, 26 Sep 2018 11:22:54 +0100 [thread overview]
Message-ID: <1537957374.8363.4.camel@debian.org> (raw)
In-Reply-To: <20180727172607.16890-1-bluca@debian.org>
On Fri, 2018-07-27 at 18:26 +0100, Luca Boccassi wrote:
> rx_drop_en is an optimization that does nothing on single-queue
> devices like e1000. Do not force applications that do not care to
> select per-devices optimizations flags by returning an error, just
> log it and carry on.
>
> Fixes: 805803445a02 ("e1000: support EM devices (also known as
> e1000/e1000e)")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> drivers/net/e1000/em_rxtx.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Ping. Any chance this could get a review? Thanks!
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-09-26 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 17:26 Luca Boccassi
2018-09-26 10:22 ` Luca Boccassi [this message]
2018-10-08 8:43 ` Zhao1, Wei
2018-10-08 14:14 ` Luca Boccassi
2018-10-10 7:25 ` Zhao1, Wei
2018-10-10 17:57 ` Zhang, Qi Z
2018-10-08 9:49 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537957374.8363.4.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).