From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 489161B13A; Wed, 26 Sep 2018 12:22:57 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id q8-v6so1698659wmq.4; Wed, 26 Sep 2018 03:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=7vfQ1OjeNCFauRor8c2yUfPTYaV02GGAppsGxrOvNOI=; b=T6sDjMQJk7aILI1EyvGRgntN4id16ZdO3fZdBHOmuf2XZBvh/5DvqhbjoNnUTSWcmF 1zWOPFmGD9/5+aq4gRnZzXzoA3MrT9/ANysbUFqOI8/C1o+AE7SeLLq6M1JlHPLu8dZB 0pWPu5sVd9oHvOZGO0ZqyBNkQtfnirHgKQ88kYt/axWPnTOUAMfO0Ojoyj+8cfXSh+WR hvXBSKxaAjcfJTzyWqJEyVJbEWOj2T8Ml/YPy2/Z9rGEF1+m8PDi4ykXUssvpBZDsbFH csk9v8JQs3fzaYjqmJKvJCnS1WSo2PXl8UsVckB6LBQgOybPwWPnK9sWoP3IeZmTifYc AyEw== X-Gm-Message-State: ABuFfoiGZlH7fHE71n1ule5T71CZp0kCAjYsCZRjvUuhPdGRTdaXMPBL vePRk6Gj6Vk76q4HADXLwrQhl1Nn X-Google-Smtp-Source: ACcGV63O8AMOEnpVACvfHk5sf1jtFhcq7K7f0YKJ7vAuoMiAEjOAaRn+Ckvoa2AsVDkUCiOTW5t6PA== X-Received: by 2002:a1c:f60c:: with SMTP id w12-v6mr3899877wmc.80.1537957376606; Wed, 26 Sep 2018 03:22:56 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:489f:80a9:5d59:c6bd]) by smtp.gmail.com with ESMTPSA id a17-v6sm252086wme.40.2018.09.26.03.22.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Sep 2018 03:22:55 -0700 (PDT) Message-ID: <1537957374.8363.4.camel@debian.org> From: Luca Boccassi To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, stable@dpdk.org, ferruh.yigit@intel.com Date: Wed, 26 Sep 2018 11:22:54 +0100 In-Reply-To: <20180727172607.16890-1-bluca@debian.org> References: <20180727172607.16890-1-bluca@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 10:22:57 -0000 On Fri, 2018-07-27 at 18:26 +0100, Luca Boccassi wrote: > rx_drop_en is an optimization that does nothing on single-queue > devices like e1000. Do not force applications that do not care to > select per-devices optimizations flags by returning an error, just > log it and carry on. >=20 > Fixes: 805803445a02 ("e1000: support EM devices (also known as > e1000/e1000e)") > Cc: stable@dpdk.org >=20 > Signed-off-by: Luca Boccassi > --- > =C2=A0drivers/net/e1000/em_rxtx.c | 7 ++++--- > =C2=A01 file changed, 4 insertions(+), 3 deletions(-) Ping. Any chance this could get a review? Thanks! --=20 Kind regards, Luca Boccassi