* [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds
@ 2018-09-26 10:17 Luca Boccassi
2018-09-26 10:48 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2018-09-26 10:17 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, wenzhuo.lu, jingjing.wu, Luca Boccassi
The sse file was added both conditionally on building for x86 and
unconditionally, which breaks the build on non-x86.
Fixes: bd29fd07ba64 ("build: add Meson files for avf PMD")
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
drivers/net/avf/meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
index b5ad9cc673..9a05ebbf4e 100644
--- a/drivers/net/avf/meson.build
+++ b/drivers/net/avf/meson.build
@@ -9,7 +9,6 @@ objs = [base_objs]
sources = files(
'avf_ethdev.c',
'avf_rxtx.c',
- 'avf_rxtx_vec_sse.c',
'avf_vchnl.c',
)
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds
2018-09-26 10:17 [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds Luca Boccassi
@ 2018-09-26 10:48 ` Ferruh Yigit
2018-09-26 10:56 ` Luca Boccassi
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-09-26 10:48 UTC (permalink / raw)
To: Luca Boccassi, dev; +Cc: bruce.richardson, wenzhuo.lu, jingjing.wu
On 9/26/2018 11:17 AM, Luca Boccassi wrote:
> The sse file was added both conditionally on building for x86 and
> unconditionally, which breaks the build on non-x86.
>
> Fixes: bd29fd07ba64 ("build: add Meson files for avf PMD")
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> drivers/net/avf/meson.build | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
> index b5ad9cc673..9a05ebbf4e 100644
> --- a/drivers/net/avf/meson.build
> +++ b/drivers/net/avf/meson.build
> @@ -9,7 +9,6 @@ objs = [base_objs]
> sources = files(
> 'avf_ethdev.c',
> 'avf_rxtx.c',
> - 'avf_rxtx_vec_sse.c',
The patch merged [1] already don't have this.
[1]
https://patches.dpdk.org/patch/44908/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds
2018-09-26 10:48 ` Ferruh Yigit
@ 2018-09-26 10:56 ` Luca Boccassi
0 siblings, 0 replies; 3+ messages in thread
From: Luca Boccassi @ 2018-09-26 10:56 UTC (permalink / raw)
To: Ferruh Yigit, dev; +Cc: bruce.richardson, wenzhuo.lu, jingjing.wu
On Wed, 2018-09-26 at 11:48 +0100, Ferruh Yigit wrote:
> On 9/26/2018 11:17 AM, Luca Boccassi wrote:
> > The sse file was added both conditionally on building for x86 and
> > unconditionally, which breaks the build on non-x86.
> >
> > Fixes: bd29fd07ba64 ("build: add Meson files for avf PMD")
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > drivers/net/avf/meson.build | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/avf/meson.build
> > b/drivers/net/avf/meson.build
> > index b5ad9cc673..9a05ebbf4e 100644
> > --- a/drivers/net/avf/meson.build
> > +++ b/drivers/net/avf/meson.build
> > @@ -9,7 +9,6 @@ objs = [base_objs]
> > sources = files(
> > 'avf_ethdev.c',
> > 'avf_rxtx.c',
> > - 'avf_rxtx_vec_sse.c',
>
> The patch merged [1] already don't have this.
>
> [1]
> https://patches.dpdk.org/patch/44908/
Lol, I used an old git branch to check Bruce's patch, thanks, changed
status on patchwork
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-26 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 10:17 [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds Luca Boccassi
2018-09-26 10:48 ` Ferruh Yigit
2018-09-26 10:56 ` Luca Boccassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).