DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: improve error message for missing dependency
Date: Thu, 26 Jul 2018 10:05:42 +0200	[thread overview]
Message-ID: <1538032.sZLDVcAvc4@xps> (raw)
In-Reply-To: <20180720132825.772-1-bruce.richardson@intel.com>

20/07/2018 15:28, Bruce Richardson:
> When building a driver or library and a required internal dependency
> is missing, the error message printed was:
> 
>     Tried to get unknown variable "shared_rte_<libname>".
> 
> However, a better way to handle this is to catch the missing variable
> earlier and convert it into a proper message, informing the user
> that the required dependency is missing, and most importantly, what
> library or driver wanted that dependency.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

      reply	other threads:[~2018-07-26  8:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 13:28 Bruce Richardson
2018-07-26  8:05 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538032.sZLDVcAvc4@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).