From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 800CF1B139 for ; Thu, 27 Sep 2018 09:51:00 +0200 (CEST) Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 89FC4856040A22C8F1DE; Thu, 27 Sep 2018 15:50:59 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id w8R7oq02091205; Thu, 27 Sep 2018 15:50:52 +0800 (GMT-8) (envelope-from han.li1@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2018092715512187-1411894 ; Thu, 27 Sep 2018 15:51:21 +0800 From: Li Han To: qi.z.zhang@intel.com Cc: dev@dpdk.org, Li Han Date: Thu, 27 Sep 2018 03:26:30 -0400 Message-Id: <1538033190-2884-1-git-send-email-han.li1@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2018-09-27 15:51:22, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2018-09-27 15:50:40, Serialize complete at 2018-09-27 15:50:40 X-MAIL: mse01.zte.com.cn w8R7oq02091205 Subject: [dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 07:51:00 -0000 in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID,and in function "i40e_nvmupd_command" when "upd_cmd == I40E_NVMUPD_STATUS",it check "!cmd->data_size" again, but it's no need. Signed-off-by: Li Han --- drivers/net/i40e/base/i40e_nvm.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index c77dac0..5de22e4 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -869,11 +869,6 @@ enum i40e_status_code i40e_nvmupd_command(struct i40e_hw *hw, * going into the state machine */ if (upd_cmd == I40E_NVMUPD_STATUS) { - if (!cmd->data_size) { - *perrno = -EFAULT; - return I40E_ERR_BUF_TOO_SHORT; - } - bytes[0] = hw->nvmupd_state; if (cmd->data_size >= 4) { -- 1.8.3.1