From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 96527374F for ; Thu, 6 Oct 2016 11:41:09 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id f193so278978197wmg.0 for ; Thu, 06 Oct 2016 02:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=J4c3zPp6cNS09ufPH2OdAMFhJ+YOLOPcqz1lG4D488Y=; b=G3sIKMKzqArxMJyh1+PhVP4DJa6KQakRVA8SI9VK309cPwYsYnnv4L4527jAz0A1L1 2VPmtzNRq+Fw8ydnwQoTuSmxeGxrRPiHAdQRUvGRZVwK7L+g3bmCZ8+gSjbbPVa0u+rn 5EjMFupOuYsNhedfsbIUDy5xl4lRWQIt0UDhtmDG3vKT2m9tL9gS+CfKhIJecwVlI4uh nsi61T2EEMFtFvLvAlQoguv+b5TBsdAXB2mT3kRfYozzFy2t98Fm0vY91DoAlSVTtNd8 fworeYaTbG5/2KVOVTOGXJo3F+tQSaegsq1GxjYShYTr04GjrIxF8fHIMsgGHIHY59uf kz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=J4c3zPp6cNS09ufPH2OdAMFhJ+YOLOPcqz1lG4D488Y=; b=GMUhd6KxVl9xS/dpvdW3ipYLfu9wSvXJmhCtM+QytMiYWRY8BB9/++R8LM1r/OZyMO npJRH+Aq1maA/Qj7UkWZbYCgVDQigZ1ysqW+eJa4HRRcExFmmwEPVx6cuPlVBrq5wrR1 3V5z48dEMQKwMBmxwLdWWD+uhJ7wvuWLasYxKlh8l5cs8lIVoxDB4za4UNWPySHiNk0s IZHX7pkVOvrU8wHQw5byrHASI92/IK5k0KD04v66APnsZyFRcRllC4zhZNRSddY/wBCM ZnBIGeUrxVE/j+rZf3VxcLlpJP6fhait8dBGSJlkpf1IJCRTNd57SLd2vYkEvhv2HDMR nj8A== X-Gm-Message-State: AA6/9Rlv2nFjak6mKwdPlYTXpz0TUmJn7EQRHlEyyl0HOf6KScVTG6Y/5HclpYO8JX2rW+yu X-Received: by 10.28.35.68 with SMTP id j65mr15899569wmj.107.1475746869416; Thu, 06 Oct 2016 02:41:09 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id lz5sm13413666wjb.24.2016.10.06.02.41.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 02:41:08 -0700 (PDT) From: Thomas Monjalon To: Marcin Kerlin Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, sergio.gonzalez.monroy@intel.com Date: Thu, 06 Oct 2016 11:41:06 +0200 Message-ID: <1538060.S3DiiuebUu@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1475244055-6309-2-git-send-email-marcinx.kerlin@intel.com> References: <1474974783-4861-2-git-send-email-marcinx.kerlin@intel.com> <1475244055-6309-1-git-send-email-marcinx.kerlin@intel.com> <1475244055-6309-2-git-send-email-marcinx.kerlin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/2] librte_ether: add protection against overwrite device data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 09:41:09 -0000 Hi Marcin, 2016-09-30 16:00, Marcin Kerlin: > Added protection against overwrite device data in array rte_eth_dev_data[] > for the next secondary applications. Secondary process appends in the > first free place rather than at the beginning. This behavior prevents > overwriting devices data of primary process by secondary process. I've just realized that you are trying to fix an useless code. Why not just remove the array rte_eth_dev_data[] at first? We already have the array rte_eth_devices[] and there is a pointer to rte_eth_dev_data in rte_eth_dev. Is it just a workaround to be able to lookup the rte_eth_dev_data memzone in the secondary process? So wouldn't it be saner to have rte_eth_devices[] in a memzone? Sergio, as the multi-process maintainer, I guess you have an idea :)