DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Timothy Redaelli <tredaelli@redhat.com>
Cc: dev@dpdk.org, mvarlese@suse.de, christian.ehrhardt@canonical.com
Subject: Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option
Date: Mon, 01 Oct 2018 12:24:06 +0100	[thread overview]
Message-ID: <1538393046.8363.42.camel@debian.org> (raw)
In-Reply-To: <20181001110600.GA2520@bricha3-MOBL.ger.corp.intel.com>

On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote:
> On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote:
> > On Mon, 01 Oct 2018 10:46:02 +0100
> > Luca Boccassi <bluca@debian.org> wrote:
> > 
> > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson
> > > > wrote:  
> > > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi
> > > > > wrote:  
> > > > > > Allow users and packagers to override the default
> > > > > > dpdk/drivers
> > > > > > subdirectory where the PMDs get installed under $lib.
> > > > > > 
> > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > > ---  
> > > > > 
> > > > > I'm ok with this change, but what is the current location
> > > > > used by
> > > > > distro's
> > > > > right now? I mistakenly never checked what was done before I
> > > > > used
> > > > > dpdk/drivers as a default value, and I'd like the default to
> > > > > match
> > > > > the
> > > > > common option if possible.
> > > > > 
> > > > > /Bruce
> > > > >   
> > > > 
> > > > Replying to my own question, I've just checked on CentOS and
> > > > Debian,
> > > > and it
> > > > appears both are using directory "dpdk-pmds" as the subdir
> > > > name.
> > > > Therefore,
> > > > let's just make that the default. [Does it need to be
> > > > configurable in
> > > > that
> > > > case?]
> > > > 
> > > > /Bruce  
> > > 
> > > If the default is the one I expect then I'm fine without having
> > > an
> > > option (actually happier - less things to configure).
> > > 
> > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last
> > > January :-)
> > > We changed because using a single directory creates problems when
> > > multiple different ABI versions are installed, due to the EAL
> > > autoload
> > > from that directory. So we need a different subdirectory per ABI
> > > revision.
> > > 
> > > We were actually talking with Timothy a while ago to make this
> > > consistent across our distros, and perhaps Marco can chip in as
> > > well.
> > > 
> > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm
> > > not
> > > too fussy on $something, it can be drivers or pmds or something
> > > else.
> > > 
> > 
> > LGTM.
> > If needed, we can just do a compatibility symlink using the current
> > dpdk-pmds path
> > 
> 
> One suggestion/comment. Would using a unique directory per release
> not lead
> to clobbering up the lib directory unnecessarily? How about having a
> single
> "dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as a
> subdir
> under that?
> 
> E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/
> dpdk-pmds/18.11
> 
> [The former of the above would be my preference, since I don't like
> having
> hypenated names, and like having "dpdk" alone as a folder name :-)]
> 
> /Bruce

dpdk/pmds-XX.YY/ would work for me. Timothy and Marco?

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2018-10-01 11:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 17:58 Luca Boccassi
2018-10-01  9:17 ` Bruce Richardson
2018-10-01  9:25   ` Bruce Richardson
2018-10-01  9:46     ` Luca Boccassi
2018-10-01 10:01       ` Bruce Richardson
2018-10-01 10:42       ` Timothy Redaelli
2018-10-01 11:06         ` Bruce Richardson
2018-10-01 11:24           ` Luca Boccassi [this message]
2018-10-02 11:02             ` Marco Varlese
2018-10-02 12:23               ` Bruce Richardson
2018-10-02 13:07                 ` Luca Boccassi
2018-10-02 13:06 ` [dpdk-dev] [PATCH v2 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Luca Boccassi
2018-10-02 13:06   ` [dpdk-dev] [PATCH v2 2/2] build: add drivers_install_subdir meson option Luca Boccassi
2018-10-02 14:28     ` Bruce Richardson
2018-10-02 14:59       ` Luca Boccassi
2018-10-02 15:19         ` Bruce Richardson
2018-10-02 15:26           ` Luca Boccassi
2018-10-02 15:25 ` [dpdk-dev] [PATCH v3 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Luca Boccassi
2018-10-02 15:25   ` [dpdk-dev] [PATCH v3 2/2] build: add drivers_install_subdir meson option Luca Boccassi
2018-10-02 15:58     ` Bruce Richardson
2018-10-02 16:21       ` Luca Boccassi
2018-10-02 16:20 ` [dpdk-dev] [PATCH v4 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Luca Boccassi
2018-10-02 16:20   ` [dpdk-dev] [PATCH v4 2/2] build: add drivers_install_subdir meson option Luca Boccassi
2018-10-02 16:30     ` Bruce Richardson
2018-10-05 16:00     ` Timothy Redaelli
2018-10-02 16:28   ` [dpdk-dev] [PATCH v4 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Bruce Richardson
2018-10-05 16:00   ` Timothy Redaelli
2018-10-27 21:19   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538393046.8363.42.camel@debian.org \
    --to=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=mvarlese@suse.de \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).