From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C28FB1B39C; Mon, 1 Oct 2018 17:37:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 08:37:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,328,1534834800"; d="scan'208";a="88240646" Received: from sivswdev01.ir.intel.com (HELO localhost.localdomain) ([10.237.217.45]) by orsmga003.jf.intel.com with ESMTP; 01 Oct 2018 08:36:57 -0700 From: Fiona Trahe To: dev@dpdk.org Cc: akhil.goyal@nxp.com, stable@dpdk.org, tomaszx.jozwiak@intel.com, Fiona Trahe Date: Mon, 1 Oct 2018 16:36:52 +0100 Message-Id: <1538408212-31349-1-git-send-email-fiona.trahe@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH] drivers/qat: fix failure to create PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 15:37:19 -0000 If QAT crypto pmd failed to be created due to reaching max allowed cryptodevs it prevented QAT comp PMD being created. And vice versa. Change to warning in these cases and allow the other PMD to be created. Fixes: c0c90bc4cade ("compress/qat: add create and destroy functions") Cc: stable@dpdk.org Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 6 ++++-- drivers/crypto/qat/qat_sym_pmd.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c index 63af23a..6510cca 100644 --- a/drivers/compress/qat/qat_comp_pmd.c +++ b/drivers/compress/qat/qat_comp_pmd.c @@ -389,8 +389,10 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev) sizeof(struct qat_comp_dev_private), &init_params); - if (compressdev == NULL) - return -ENODEV; + if (compressdev == NULL) { + QAT_LOG(WARNING, "Failed to create QAT COMP device %s", name); + return 0; + } compressdev->dev_ops = &compress_qat_ops; diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c index c3f7004..82fde16 100644 --- a/drivers/crypto/qat/qat_sym_pmd.c +++ b/drivers/crypto/qat/qat_sym_pmd.c @@ -261,8 +261,10 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev) cryptodev = rte_cryptodev_pmd_create(name, &(qat_pci_dev->sym_rte_dev), &init_params); - if (cryptodev == NULL) - return -ENODEV; + if (cryptodev == NULL) { + QAT_LOG(WARNING, "Failed to create QAT SYM device %s", name); + return 0; + } qat_pci_dev->sym_rte_dev.name = cryptodev->data->name; cryptodev->driver_id = cryptodev_qat_driver_id; -- 2.7.4