From: eric zhang <eric.zhang@windriver.com>
To: <anatoly.burakov@intel.com>, <john.mcnamara@intel.com>
Cc: <allain.legacy@windriver.com>, <matt.peters@windriver.com>,
<dev@dpdk.org>
Subject: [dpdk-dev] [PATCH v3 2/3] eal: force IOVA to a particular mode
Date: Wed, 3 Oct 2018 16:53:13 -0400 [thread overview]
Message-ID: <1538599994-23331-3-git-send-email-eric.zhang@windriver.com> (raw)
In-Reply-To: <1538599994-23331-1-git-send-email-eric.zhang@windriver.com>
This patch uses EAL option "--iova-mode" to force the IOVA mode to a
particular value. There exists virtual devices that are not directly
attached to the PCI bus, and therefore the auto detectioni of the IOVA
mode based on probing the PCI bus and IOMMU configuration may not
report the required addressing mode. Using the EAL option permits the
mode to be explicitly configured in this scenario.
Signed-off-by: eric zhang <eric.zhang@windriver.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 11 +++++++++--
lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++----------
2 files changed, 26 insertions(+), 12 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 369a682..5392f06 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -569,8 +569,15 @@ static void rte_eal_init_alert(const char *msg)
return -1;
}
- /* autodetect the iova mapping mode (default is iova_pa) */
- rte_eal_get_configuration()->iova_mode = rte_bus_get_iommu_class();
+ /* if no eal option "--iova-mode=<pa|va>", use bus iova scheme */
+ if (internal_config.iova_mode == RTE_IOVA_DC) {
+ /* autodetect the iova mapping mode (default is iova_pa) */
+ rte_eal_get_configuration()->iova_mode =
+ rte_bus_get_iommu_class();
+ } else {
+ rte_eal_get_configuration()->iova_mode =
+ internal_config.iova_mode;
+ }
if (internal_config.no_hugetlbfs == 0 &&
internal_config.process_type != RTE_PROC_SECONDARY &&
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index e0b5ae1..1af9458 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -805,16 +805,23 @@ static void rte_eal_init_alert(const char *msg)
return -1;
}
- /* autodetect the iova mapping mode (default is iova_pa) */
- rte_eal_get_configuration()->iova_mode = rte_bus_get_iommu_class();
-
- /* Workaround for KNI which requires physical address to work */
- if (rte_eal_get_configuration()->iova_mode == RTE_IOVA_VA &&
- rte_eal_check_module("rte_kni") == 1) {
- rte_eal_get_configuration()->iova_mode = RTE_IOVA_PA;
- RTE_LOG(WARNING, EAL,
- "Some devices want IOVA as VA but PA will be used because.. "
- "KNI module inserted\n");
+ /* if no eal option "--iova-mode=<pa|va>", use bus iova scheme */
+ if (internal_config.iova_mode == RTE_IOVA_DC) {
+ /* autodetect the iova mapping mode (default is iova_pa) */
+ rte_eal_get_configuration()->iova_mode =
+ rte_bus_get_iommu_class();
+
+ /* Workaround for KNI which requires physical address to work */
+ if (rte_eal_get_configuration()->iova_mode == RTE_IOVA_VA &&
+ rte_eal_check_module("rte_kni") == 1) {
+ rte_eal_get_configuration()->iova_mode = RTE_IOVA_PA;
+ RTE_LOG(WARNING, EAL,
+ "Some devices want IOVA as VA but PA will be used because.. "
+ "KNI module inserted\n");
+ }
+ } else {
+ rte_eal_get_configuration()->iova_mode =
+ internal_config.iova_mode;
}
if (internal_config.no_hugetlbfs == 0 &&
--
1.8.3.1
next prev parent reply other threads:[~2018-10-03 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 20:53 [dpdk-dev] [PATCH v3 0/3] " eric zhang
2018-10-03 20:53 ` [dpdk-dev] [PATCH v3 1/3] eal: add eal option to configure iova mode eric zhang
2018-10-03 20:53 ` eric zhang [this message]
2018-10-03 20:53 ` [dpdk-dev] [PATCH v3 3/3] doc: document --iova-mode EAL option eric zhang
2018-10-18 13:18 ` Kovacevic, Marko
2018-10-04 9:19 ` [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode Burakov, Anatoly
2018-10-11 10:08 ` Thomas Monjalon
2018-10-28 23:04 ` Thomas Monjalon
2018-10-30 12:02 ` Alejandro Lucero
2018-10-30 13:47 ` Burakov, Anatoly
2018-10-30 14:03 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538599994-23331-3-git-send-email-eric.zhang@windriver.com \
--to=eric.zhang@windriver.com \
--cc=allain.legacy@windriver.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=matt.peters@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).