From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF8EEA00C2; Wed, 24 Aug 2022 11:42:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B668F40DFD; Wed, 24 Aug 2022 11:42:52 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 6B19440DDE for ; Wed, 24 Aug 2022 11:42:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PcT09dt4PlUTwx2NJDVGQPhqMqTUed4OlEXGUb9Vu/n/dls7vNv/wIsjGz473TUdDBx9P+1wDrK916mYnZHKBa+qIxdXk24zWVGY1aajfPlmjemDJ6YGYo77rCjQkDtBVklAyIXW9USkWh7hIvgjkGg8hrSTUvc8Xg1Kdxp6QyaJJq5nhy1YpKXzxmhzGIwlHRbrEMaENj0z/EdrD16A1sPROdUjmd7yq+TS8whzs+7vsLbin5S7uNq408zUK9F6aYmyjYOdk1syza1fG1K5z7ithe7mAp291eJcAgvMZmwNZHIsSFVCJkZ/zmEMoZPwZXDQyW6iU4q5/98GKsQtcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H2Y4LjvGZxbTgM1epJ1zgJzta2Cft7WwDZ8Jj5QlsGw=; b=PJk/4OFj4j4SDivLznNeBAdvE5s4K9nKr0l0Qlj63jseEbYLaQQjLdiOECAOo+c4XfPzuCXoHUFTJY7U1GsZCw173Q/O6PRO/fXbthCU55sZ+m14/pX1pcSKsQrSd/1JkjiLRJgvm6VPaFVZZFBhLGqZfzpYxBgFR3TDUq99uP9pGcuIhifQXuoo/fwfJROFhMsMjY06GjyVYKQNyUlIx7wSZegiJN9qwbXtkkcykmXySahHaqfpSOamwYYJ9E27ZQhlTCZwcwhlQoI48uxlmuxpelTkP2b62yOEzYRA7hxeSvNxP8cJrZt7+7rgp7WXf2FYB0EZDWblswb581Cfyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H2Y4LjvGZxbTgM1epJ1zgJzta2Cft7WwDZ8Jj5QlsGw=; b=Q8Dnf2N3rfP5E8npdEgGHb38ifjnalDs6zwe5qB6gxQ4P6Tp/T5kJpbOomSfKa1wMj2VuICIYSR7T0v5zGITYn/cZPuVAIuvTM4oFCbOgOhY+0EmtgxNgaw88QqVMTdaJHpJe2SJhVhWBVhTFABnF85GSIc1DJbW9tU5WkSXH3w= Received: from BN9PR03CA0360.namprd03.prod.outlook.com (2603:10b6:408:f6::35) by MW4PR02MB7108.namprd02.prod.outlook.com (2603:10b6:303:73::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Wed, 24 Aug 2022 09:42:49 +0000 Received: from BN1NAM02FT033.eop-nam02.prod.protection.outlook.com (2603:10b6:408:f6:cafe::24) by BN9PR03CA0360.outlook.office365.com (2603:10b6:408:f6::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22 via Frontend Transport; Wed, 24 Aug 2022 09:42:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT033.mail.protection.outlook.com (10.13.3.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Wed, 24 Aug 2022 09:42:47 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 24 Aug 2022 10:42:46 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 24 Aug 2022 10:42:46 +0100 Envelope-to: andrew.rybchenko@oktetlabs.ru, qiming.yang@intel.com, wenjun1.wu@intel.com, jiawenwu@trustnetic.com, jianwang@trustnetic.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, rmody@marvell.com, dsinghrawat@marvell.com, dev@dpdk.org, thomas@monjalon.net Received: from [10.71.194.74] (port=31705) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oQmuL-0006VY-L0; Wed, 24 Aug 2022 10:42:46 +0100 Message-ID: <153881f1-70c7-0c63-3f40-280f6c867403@xilinx.com> Date: Wed, 24 Aug 2022 10:42:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 0/3] ethdev: remove deprecated Flow Director configuration Content-Language: en-US To: Andrew Rybchenko , Qiming Yang , Wenjun Wu , Jiawen Wu , Jian Wang , Yuying Zhang , Beilei Xing , Rasesh Mody , Devendra Singh Rawat CC: , Thomas Monjalon References: <20220803111358.375544-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <20220803111358.375544-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5a23e66-2874-43f4-bfd3-08da85b500eb X-MS-TrafficTypeDiagnostic: MW4PR02MB7108:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HQA7IFOa1trJD650EQcHFXQxNz1XMgAliUkUBWTvV0u/Fs1/qg1NPQhXiSenYAv0+pf/CLxVkfItr6ey7KNEK+UbKmRw9+Upl9JvNBAqJezT5CTZP8WVmev5aw6Xf5AOoOJ8BtDy3m2EW1/4x5LPspTigWGIt2gGH3bluH7k9aUkuiGIKfpBbw5ivLN3a6c6WxGoCOKz5glds8V3baJ2qhuXyoPb5+aBfDaZualU36C+D3lkm1+05GrgqeVXFIqobOybsgD0g22x8iTPFko7GijwldRxAxBc+tnsdMwLN0w5WFRORYYrh/fjPumEVpbtxFoFu6a6TKOdKPoffhi6eKc2TzuQQI+j0+bX4iMvigxy3bP2OMmDM+Lomi7e5g0eP/j7DQwLl/6PW/n6Zg+zw62RveoDPQYPwVykVegCv2e5dOtA9nTxyvrxuovbEQVCnRM/CloOAlP+sZPWtGRqdHSiq5chD0/2fYJP3qlTw4VNSVvtSLcbQ13mD/gPhbkuPYllUogO2Qid3Bdxq7SQn2FEZLlxfQ31a+PHgWtnmiNS9ZD7QxFbx1+441DkUDHtY5KsAQYdj5apYPxp66145wrb1c8lUi2XYHxM5RCUpbxK+UQchLd9xHjhOMArtHnEGvvU8xsQ32e3KN/5r2Ct+ovizU1e2Q3BoDIbVEtVAYmCE9LAxD7EO0ltfIiP58uXxPm3DJRLA0qIACtbAcK7TWx3CH1FnWMTQs5BHqEFdwqJXetFw/RFwuFKZ9pHrjQccfAcsAXM7fPHiyytfi/kIeSuOO0HHH5sGI8fppvr4MjCeV4IaD/uO5LhANvKPgEH8MYNo/N3xPSS8Bx05ljD0sjfnh06jmMAUObZUljoVx8= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(36840700001)(40470700004)(26005)(47076005)(53546011)(82310400005)(2616005)(31696002)(41300700001)(478600001)(40480700001)(336012)(82740400003)(40460700003)(7636003)(356005)(186003)(83380400001)(36756003)(36860700001)(2906002)(426003)(316002)(44832011)(9786002)(7416002)(54906003)(31686004)(4744005)(8936002)(5660300002)(70206006)(8676002)(70586007)(110136005)(4326008)(50156003)(557034005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 09:42:47.5652 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5a23e66-2874-43f4-bfd3-08da85b500eb X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT033.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7108 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/3/2022 12:13 PM, Andrew Rybchenko wrote: > Flow Director configuration fdir_conf was deprecated long time ago and > was planned to be removed in 20.11. > > i40e, ixgbe, qede and txgbe driver maintainers are encouraged to review > correspodning patches very carefully. > > Internal copy of the Flow Director configuration in ixgbe and txgbe > drivers is not actually initialized. Should I use configuration from > testpmd as the default one? > > Andrew Rybchenko (3): > net/ixgbe: add helper to get Flow Director configuration > net/txgbe: add helper to get Flow Director configuration > ethdev: remove deprecated Flow Director configuration > Thanks Andrew, this is one of the long lasting deprecating notices. Change looks good to me, but impacted driver (ixgbe, txgbe, i40e, qede) maintainers, can you please looks at the change, if there is no comment it will proceed.