DPDK patches and discussions
 help / color / mirror / Atom feed
From: Mordechay Haimovsky <motih@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	"orika@contextream.com" <orika@contextream.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Mordechay Haimovsky <motih@mellanox.com>
Subject: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name conversion
Date: Sun, 7 Oct 2018 16:22:11 +0000	[thread overview]
Message-ID: <1538929311-31815-1-git-send-email-motih@mellanox.com> (raw)
In-Reply-To: <1538926667-23009-1-git-send-email-motih@mellanox.com>

This patch fixes a typecast bug found in rte_flow_conv_name routine
used in rte_flow item/action name conversion.

Fixes: 0c2640cbfa7a ("ethdev: add flow API item/action name conversion")

Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
v1:
 Fixed wrong hash number in "Fixes" message.
--- 
 lib/librte_ethdev/rte_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index 9c56a97..21a4286 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -767,7 +767,7 @@ enum rte_flow_conv_item_spec_type {
 		{ rte_flow_desc_action, RTE_DIM(rte_flow_desc_action), },
 	};
 	const struct desc_info *const info = &info_rep[!!is_action];
-	unsigned int type = (uintptr_t)src;
+	unsigned int type = *(const unsigned int *)src;
 
 	if (type >= info->num)
 		return rte_flow_error_set
-- 
1.8.3.1

  reply	other threads:[~2018-10-07 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-07 15:38 [dpdk-dev] [PATCH] " Mordechay Haimovsky
2018-10-07 16:22 ` Mordechay Haimovsky [this message]
2018-10-07 16:31   ` [dpdk-dev] [PATCH v1] " Ori Kam
2018-10-09 13:21     ` Ferruh Yigit
2018-10-09 13:38       ` Ferruh Yigit
2018-10-09 13:54       ` Adrien Mazarguil
2018-10-11 10:14         ` Ferruh Yigit
2018-10-11 10:36           ` Mordechay Haimovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538929311-31815-1-git-send-email-motih@mellanox.com \
    --to=motih@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=orika@contextream.com \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).