From: Mordechay Haimovsky <motih@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Mordechay Haimovsky <motih@mellanox.com>
Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
Date: Wed, 10 Oct 2018 17:04:56 +0000 [thread overview]
Message-ID: <1539191078-8501-1-git-send-email-motih@mellanox.com> (raw)
This patch fixes a bug found in port_flow_query routine which caused
flow query command to fail with the following error "Caught error
type 1 (cause unspecified): unknown object type to retrieve the name
of: Invalid argument".
Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function")
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
app/test-pmd/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 009c92c..b11317b 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1239,7 +1239,8 @@ void print_valid_ports(void)
return -ENOENT;
}
ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR,
- &name, sizeof(name), action, &error);
+ &name, sizeof(name),
+ (void *)(uintptr_t)action->type, &error);
if (ret < 0)
return port_flow_complain(&error);
switch (action->type) {
--
1.8.3.1
next reply other threads:[~2018-10-10 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 17:04 Mordechay Haimovsky [this message]
2018-10-10 18:56 ` John Daley (johndale)
2018-10-11 10:40 ` Mordechay Haimovsky
2018-10-11 9:29 ` Adrien Mazarguil
2018-10-11 10:15 ` Ori Kam
2018-10-11 10:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539191078-8501-1-git-send-email-motih@mellanox.com \
--to=motih@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).