From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 6A2C81B4F1 for ; Thu, 11 Oct 2018 12:53:15 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id 185-v6so8933805wmt.2 for ; Thu, 11 Oct 2018 03:53:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=/G1+B1/4bCIFjiBXKoEtCEEd4LzxON5qfk7JvDbsnBQ=; b=pPVvsBtD+6an3+XeFEa88/TMABgdqTPf2Hlh4VX3inLMI+cXu7+5HWfhPMR3w18umq 0QR8uB50bQeWnvZ4Qv3KidijkMwrpPM2opnwWnAmbak1lOubkNItkUoMy8/UVA2hiACW CVrFClIvmrRpY7vmWDG4LlAqx7eAe+q3gL7gt6LhHyQoSv2XeLwpfOO3uyDdlnId0AV1 GMqHVSnrvaTVhEbDAnilEdY73vkHMdaxTfWdY5p0S1Iy/YQcHNMoLHjnJtcziL8jy67T CZ/sB26886UQucvJPe5+2kVgEpXNtrHFxewKP8TPbinPznNXNaoQulKtE1qzSDneaeGc 20Iw== X-Gm-Message-State: ABuFfogRhFC3JcTEKPBQQil0E/v0D+sEwARTjht0sg0c2bKVk6de0S5v W07jI9eK5cdIo3un/CWLSSk= X-Google-Smtp-Source: ACcGV60eUaWWwI0Nn1DJvQuWaDW3KcduP4z8VWSY6rQpeAbzuw4W6s5OHkCcVx8x0EDqe5thNiZerw== X-Received: by 2002:a1c:603:: with SMTP id 3-v6mr1207232wmg.64.1539255194885; Thu, 11 Oct 2018 03:53:14 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 82-v6sm23222833wms.17.2018.10.11.03.53.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Oct 2018 03:53:13 -0700 (PDT) Message-ID: <1539255192.8721.31.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, tiwei.bie@intel.com, bruce.richardson@intel.com, brian.russell@intl.att.com Date: Thu, 11 Oct 2018 11:53:12 +0100 In-Reply-To: <2276842.FSxJgd8eX6@xps> References: <20180827165240.28322-1-bluca@debian.org> <20180828101240.12597-1-bluca@debian.org> <20180828101240.12597-2-bluca@debian.org> <2276842.FSxJgd8eX6@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] net/virtio: fix PCI config err handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 10:53:15 -0000 On Thu, 2018-10-11 at 12:27 +0200, Thomas Monjalon wrote: > 28/08/2018 12:12, Luca Boccassi: > > From: Brian Russell > >=20 > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config > > returns > > the number of bytes read from PCI config or < 0 on error. > > If less than the expected number of bytes are read then log the > > failure and return rather than carrying on with garbage. > >=20 > > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") > >=20 > > Signed-off-by: Brian Russell > > Signed-off-by: Luca Boccassi > > --- > > v2: handle additional rte_pci_read_config incomplete reads > > v3: do not handle rte_pci_read_config of virtio cap, added in v2, > > =C2=A0=C2=A0=C2=A0=C2=A0as it's less clear what the right thing to do t= here is > > v4: do a more robust check - first check what the vendor is, and > > =C2=A0=C2=A0=C2=A0=C2=A0skip the cap entirely if it's not what we are l= ooking for. > > v5: fetch only 2 flags bytes if the vndr is PCI_CAP_ID_MSIX > > v6: fix 32bit build by changing the printf format specifier, fix > > patch title >=20 > Tiwei did a comment on v5 and provided his Reviewed-by. > Is it OK to apply v6 with its tag? > All is fixed? Hi, The title has been fixed (virtio -> net/virtio) and I just tried a 32bit build and it works fine after the fix from v6. --=20 Kind regards, Luca Boccassi