[dpdk-dev] [PATCH 1/2] net/sfc: allow to query RSS key and HF in isolated mode

[dpdk-dev] [PATCH 1/2] net/sfc: allow to query RSS key and HF in isolated mode

[Andrew Rybchenko]

From: Ivan Malov <ivan.malov@oktetlabs.ru>

Isolated mode prevents global RSS from being enabled and configured.
However, an application may need to query default RSS key and hash
functions when a flow rule with RSS action is added which does not
contain custom RSS key or hash function choice. In this case
global RSS key and hash functions will be used to handle the rule,
and there should be some way for the application to query these
global default settings to clarify expectations on the traffic
distribution.

Fixes: 84a9b48128c1 ("net/sfc: support flow API isolated mode")
Cc: stable@dpdk.org

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 93bfecc4e..00f088013 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -1354,9 +1354,8 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 {
 	struct sfc_adapter *sa = dev->data->dev_private;
 	struct sfc_rss *rss = &sa->rss;
-	struct sfc_port *port = &sa->port;
 
-	if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || port->isolated)
+	if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE)
 		return -ENOTSUP;
 
 	if (rss->channels == 0)
-- 
2.17.1

[dpdk-dev] [PATCH 2/2] net/sfc: allow to query RSS key and HF when RSS is disabled

[Andrew Rybchenko]

From: Ivan Malov <ivan.malov@oktetlabs.ru>

If global RSS is not enabled in the multiqueue mode setting,
it will not be possible to change RSS configuration. However,
querying default RSS settings should be possible in any case since
it may be needed by RTE flow API users to find out what RSS settings
will be used by default for a flow rule with RSS action if custom
RSS key and hash function choice are not specified.

Fixes: 63ab5e0c8fda ("net/sfc: use zero RSS channels as disabled RSS indicator")
Cc: stable@dpdk.org

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 00f088013..b2e17f26e 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -1358,9 +1358,6 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 	if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE)
 		return -ENOTSUP;
 
-	if (rss->channels == 0)
-		return -EINVAL;
-
 	sfc_adapter_lock(sa);
 
 	/*
-- 
2.17.1

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/sfc: allow to query RSS key and HF in isolated mode

[Ferruh Yigit]

On 10/11/2018 3:51 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> 
> Isolated mode prevents global RSS from being enabled and configured.
> However, an application may need to query default RSS key and hash
> functions when a flow rule with RSS action is added which does not
> contain custom RSS key or hash function choice. In this case
> global RSS key and hash functions will be used to handle the rule,
> and there should be some way for the application to query these
> global default settings to clarify expectations on the traffic
> distribution.
> 
> Fixes: 84a9b48128c1 ("net/sfc: support flow API isolated mode")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Series applied to dpdk-next-net/master, thanks.