From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by dpdk.org (Postfix) with ESMTP id 18C611B3F5 for ; Fri, 12 Oct 2018 19:42:16 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id i8-v6so13000123wmg.0 for ; Fri, 12 Oct 2018 10:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=sDQHBgMobTWVp1ElTcDeSktWraVwdcO9Vev9DcTEuy4=; b=Fq7xU9el0OQ6gh8H6gEwOuDop0jryXkeSswPsoN9iWnIIKBf89dQvNHKAVqhrrJe6X HuVp5cwwSq26HuI3hDajY/Z8C2009ppGJo5dOqtqsH27nPxMGcILMrhfjFmQmklQZRb6 a1SHqhKPzS/vDQlEElnElyzSR1/hWnZQLIed+QiVUN8A+zC5rL8F0IpQbfUpOjyBRUPe mwWD8IljX/5+Srq/QZivJxrM4KZ6Nf2SlYDxPDgTjOrRuJ6/T3v46SBH4/hJg8qNfc+3 ND35r+cdOHLvNMAJ5eJ6tG4Cq9ZB1Y08rjFehBM+QsJAzyflZne7iQzpUevm5trGnyds mJUw== X-Gm-Message-State: ABuFfojtNUM3lMZvcj1KuXxdSeJGagY8kp40zdmSusaFJ06C5iI9ra8X ziSUroZGgQKgj6R0HGjQ2g4= X-Google-Smtp-Source: ACcGV61QC5H+NwB9pVs7qu/oAxRQI2YhPmkTV0fOSKWjmHEPywXFiJjfltUeQT9oWcuq7Fu2vmDEVg== X-Received: by 2002:a1c:be09:: with SMTP id o9-v6mr5987964wmf.109.1539366135451; Fri, 12 Oct 2018 10:42:15 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id e196-v6sm3296589wmf.43.2018.10.12.10.42.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 10:42:14 -0700 (PDT) Message-ID: <1539366133.8721.47.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Fri, 12 Oct 2018 18:42:13 +0100 In-Reply-To: <20181012153404.46098-1-bruce.richardson@intel.com> References: <20181012153404.46098-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/test: allow taking extra arguments from environment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 17:42:16 -0000 On Fri, 2018-10-12 at 16:34 +0100, Bruce Richardson wrote: > When running unit tests automatically, either via script, from meson, > or otherwise, the same set of options may be used for each run, for > example to set a standard coremask to be used for all tests. >=20 > To facilitate this, this patch adds support for the test binary > taking > additional EAL parameters from the environment and appending them to > the > argc/argv list passed to eal init. This allows parameter modification > without having to edit test scripts etc. >=20 > There are now two environment variables which can be used for running > tests: > =C2=A0* DPDK_TEST - (added previously) passes the test name to be run > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0automatically rather than running the app > interactively. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0Used by "meson test" when running tests individually > or > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0as part of a suite. >=20 > =C2=A0* DPDK_TEST_PARAMS - new parameter to specify the commandline > arguments > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0to use with the test binary. For example to run a > test, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0or tests, on only 16 lcores, and to skip pci scan we > can > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0set this to "-l 0-15 --no-pci". >=20 > Signed-off-by: Bruce Richardson > --- > =C2=A0doc/guides/rel_notes/release_18_11.rst |=C2=A0=C2=A08 ++++++ > =C2=A0test/test/test.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| 34 > +++++++++++++++++++++++++- > =C2=A02 files changed, 41 insertions(+), 1 deletion(-) Was just thinking that something like this would be useful! Tested-by: Luca Boccassi --=20 Kind regards, Luca Boccassi