DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yipeng Wang <yipeng1.wang@intel.com>
To: bruce.richardson@intel.com
Cc: stephen@networkplumber.org, dev@dpdk.org, yipeng1.wang@intel.com,
	honnappa.nagarahalli@arm.com, sameh.gobriel@intel.com
Subject: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause
Date: Wed, 24 Oct 2018 11:09:27 -0700	[thread overview]
Message-ID: <1540404570-102126-2-git-send-email-yipeng1.wang@intel.com> (raw)
In-Reply-To: <1540404570-102126-1-git-send-email-yipeng1.wang@intel.com>

There is a rte_pause in hash table reset function.
Since the loop is not a polling loop on shared
data structure, the rte_pause is not needed.

Fixes: b26473ff8f4a ("hash: add reset function")
Cc: stable@dpdk.org

Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
---
 lib/librte_hash/rte_cuckoo_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c
index 0648a22..4a2647e 100644
--- a/lib/librte_hash/rte_cuckoo_hash.c
+++ b/lib/librte_hash/rte_cuckoo_hash.c
@@ -574,14 +574,14 @@ rte_hash_reset(struct rte_hash *h)
 
 	/* clear the free ring */
 	while (rte_ring_dequeue(h->free_slots, &ptr) == 0)
-		rte_pause();
+		continue;
 
 	/* clear free extendable bucket ring and memory */
 	if (h->ext_table_support) {
 		memset(h->buckets_ext, 0, h->num_buckets *
 						sizeof(struct rte_hash_bucket));
 		while (rte_ring_dequeue(h->free_ext_bkts, &ptr) == 0)
-			rte_pause();
+			continue;
 	}
 
 	/* Repopulate the free slots ring. Entry zero is reserved for key misses */
-- 
2.7.4

  reply	other threads:[~2018-10-25  1:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 18:09 [dpdk-dev] [PATCH v2 0/4] hash: improve multiple places Yipeng Wang
2018-10-24 18:09 ` Yipeng Wang [this message]
2018-10-25  6:31   ` [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause Mattias Rönnblom
2018-10-25  9:30     ` Bruce Richardson
2018-10-26  0:24   ` Honnappa Nagarahalli
2018-10-26  2:04     ` Wang, Yipeng1
2018-10-26 11:09       ` Bruce Richardson
2018-10-24 18:09 ` [dpdk-dev] [PATCH v2 2/4] test/hash: change multiwriter test to use jhash Yipeng Wang
2018-10-25  9:32   ` Bruce Richardson
2018-10-24 18:09 ` [dpdk-dev] [PATCH v2 3/4] test/hash: add readwrite test for ext table Yipeng Wang
2018-10-25  9:34   ` Bruce Richardson
2018-10-26  0:32   ` Honnappa Nagarahalli
2018-10-24 18:09 ` [dpdk-dev] [PATCH v2 4/4] test/hash: remove hash scaling unit test Yipeng Wang
2018-10-25  9:34   ` Bruce Richardson
2018-10-25 19:11 ` [dpdk-dev] [PATCH v3 0/6] hash: improve multiple places Yipeng Wang
2018-10-25 19:11   ` [dpdk-dev] [PATCH v3 1/6] hash: fix unnecessary pause Yipeng Wang
2018-10-25 19:11   ` [dpdk-dev] [PATCH v3 2/6] test/hash: change multiwriter test to use jhash Yipeng Wang
2018-10-25 19:11   ` [dpdk-dev] [PATCH v3 3/6] test/hash: test more corner cases in unit test Yipeng Wang
2018-10-26  5:03     ` Honnappa Nagarahalli
2018-10-26 11:02       ` Thomas Monjalon
2018-10-25 19:11   ` [dpdk-dev] [PATCH v3 4/6] test/hash: add readwrite test for ext table Yipeng Wang
2018-10-25 19:11   ` [dpdk-dev] [PATCH v3 5/6] test/hash: remove hash scaling unit test Yipeng Wang
2018-10-25 19:11   ` [dpdk-dev] [PATCH v3 6/6] test/hash: fix to add read-write test to autotest Yipeng Wang
2018-10-26  9:53   ` [dpdk-dev] [PATCH v4 0/6] hash: improve multiple places Yipeng Wang
2018-10-26  9:53     ` [dpdk-dev] [PATCH v4 1/6] hash: fix unnecessary pause Yipeng Wang
2018-10-26  9:53     ` [dpdk-dev] [PATCH v4 2/6] test/hash: change multiwriter test to use jhash Yipeng Wang
2018-10-26  9:53     ` [dpdk-dev] [PATCH v4 3/6] test/hash: test more corner cases in unit test Yipeng Wang
2018-10-26  9:53     ` [dpdk-dev] [PATCH v4 4/6] test/hash: add readwrite test for ext table Yipeng Wang
2018-10-26  9:53     ` [dpdk-dev] [PATCH v4 5/6] test/hash: remove hash scaling unit test Yipeng Wang
2018-10-26  9:53     ` [dpdk-dev] [PATCH v4 6/6] test/hash: fix to add read-write test to autotest Yipeng Wang
2018-10-26 20:15     ` [dpdk-dev] [PATCH v4 0/6] hash: improve multiple places Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1540404570-102126-2-git-send-email-yipeng1.wang@intel.com \
    --to=yipeng1.wang@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=sameh.gobriel@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).