From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 2DB296833 for ; Thu, 25 Oct 2018 19:57:12 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id 143-v6so2411618wmf.1 for ; Thu, 25 Oct 2018 10:57:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=iAp/GMMP6kJsEZp+nNYUq4/yCKNyHAJVuYFIvdNdgHc=; b=je1NR746yaoVRBjrs3fXpHcsO7cGhxB8/UOM8wbPNf59aT6uMufPqYjUR6S59S6btm 2/9BqHH+uNftNBXsZzBr5/eVVoL5PNnzIuWTmIG2SRS/Tm1Qg059apRkv3yimJk2WBVO GwSdhL6hBw8DYA3zNL17YfvAqm/RwYnD6l3xQ1qTY+H+Cpbe7H2ilQkwZOd6uKbo81Y9 JiTTdDrtbzSH2/HrDSc9WvjUevOEwBpqr+3nqdsq6+uP46qZv+uYp5KV6mOkckEV95us 9Dk3H95GtCijofw7OA6BRNx+MHaHaFJG9aparSvc9sq/AGM7StGCCajFPWl8RCJc+z4O t3Uw== X-Gm-Message-State: AGRZ1gLbZ4SY5UevrguaIWF4Hj5J0szgVtPhXUPUVQj9l3BfJYXilnuK w6EcCoNpYQDzHsINETGHk6o= X-Google-Smtp-Source: AJdET5cl2gVPC3zGiyvCJjt2nvJSiX1m0Kee/ARFynsiDQxLREPoQlwGHdGCtRXhXkQhNJ+Q5FN5YQ== X-Received: by 2002:a1c:cc0f:: with SMTP id h15-v6mr2856992wmb.1.1540490231683; Thu, 25 Oct 2018 10:57:11 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id g7-v6sm4191773wru.38.2018.10.25.10.57.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Oct 2018 10:57:10 -0700 (PDT) Message-ID: <1540490229.20953.12.camel@debian.org> From: Luca Boccassi To: Stephen Hemminger , adrien.mazarguil@6wind.com Cc: dev@dpdk.org, shahafs@mellanox.com, yskoh@mellanox.com Date: Thu, 25 Oct 2018 18:57:09 +0100 In-Reply-To: <20181025174626.9725-1-stephen@networkplumber.org> References: <20181025174626.9725-1-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mlx5: use pkg-config to handle SUSE libmnl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 17:57:12 -0000 On Thu, 2018-10-25 at 10:46 -0700, Stephen Hemminger wrote: > SUSE decided to install the libmnl include file in a non-standard > place: /usr/include/libmnl/libmnl/libmnl.h >=20 > This was probably a mistake by the SUSE package maintainer, > but hard to get fixed. Workaround the problem by pkg-config to find > the necessary include directive for libmnl. >=20 > Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads") > Signed-off-by: Stephen Hemminger > --- > =C2=A0drivers/net/mlx5/Makefile | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 1e9c0b42ac16..3bde28f20ad4 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -51,6 +51,7 @@ CFLAGS +=3D -D_DEFAULT_SOURCE > =C2=A0CFLAGS +=3D -D_XOPEN_SOURCE=3D600 > =C2=A0CFLAGS +=3D $(WERROR_FLAGS) > =C2=A0CFLAGS +=3D -Wno-strict-prototypes > +CFLAGS +=3D $(pkg-config -cflags libmnl) --cflags > =C2=A0ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) > =C2=A0CFLAGS +=3D -DMLX5_GLUE=3D'"$(LIB_GLUE)"' > =C2=A0CFLAGS +=3D -DMLX5_GLUE_VERSION=3D'"$(LIB_GLUE_VERSION)"' > @@ -59,7 +60,7 @@ LDLIBS +=3D -ldl > =C2=A0else > =C2=A0LDLIBS +=3D -libverbs -lmlx5 > =C2=A0endif > -LDLIBS +=3D -lmnl > +LDLIBS +=3D $(pkg-config -libs libmnl) --libs > =C2=A0LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > =C2=A0LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs > =C2=A0LDLIBS +=3D -lrte_bus_pci With those fixed: Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi