From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 9EE0E4C99 for ; Thu, 25 Oct 2018 20:14:24 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id l6-v6so10315449wrt.1 for ; Thu, 25 Oct 2018 11:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=q6Yn0TxkvTBq/48ZTlg5p5/O01Ak3dNLN1bLLxh3yA0=; b=tKyZ3/UcOqW6d0fX4zKMS0MMhvG91uUhd+oyk7qWbX4ofBQPomyqnpNNGU8xixgpdf uOeRNr1l+RUaTmLoJw+N7WUNEahWTvc13rXX/QzK2eKKsnTpp9Ml9vkoUXCxPp62H83S swbgJVEYGSVDWYufU1W2rbMuPxZpy6pZ+JQDc0Xo3hkQge4/DNiLk3L9As1QmZFMkiM/ CzhsDX+X7J7pAbktnZn/iIPqE+ELUoDBGU+2qsgVIx3S/npzINtKpy8rV/hiynHeaGB+ z+060ZDl4y8BH5yWab9Jf04Rw662f1ZJbBpInEnTsZiUgP32UbCen8aB3cR3tWR70bIS s9bg== X-Gm-Message-State: AGRZ1gKOp7NPM1FNyFHDGSBBGcglDDrb2/aIgEylqo9SnMhFlzzqxnXz njrQvauETrCNNjLW8UOpzZ0= X-Google-Smtp-Source: AJdET5eOzeoPxSjiKhoMARsZJPoyx4RzKSWMlpQT9ss5JHS2RNlauLeQVQF/zARX5BMbcPZBSc5dPg== X-Received: by 2002:adf:ef41:: with SMTP id c1-v6mr2788490wrp.33.1540491264151; Thu, 25 Oct 2018 11:14:24 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 203-v6sm3118384wmn.34.2018.10.25.11.14.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Oct 2018 11:14:22 -0700 (PDT) Message-ID: <1540491261.20953.14.camel@debian.org> From: Luca Boccassi To: Stephen Hemminger , adrien.mazarguil@6wind.com Cc: dev@dpdk.org, shahafs@mellanox.com, yskoh@mellanox.com, mvarlese@suse.de Date: Thu, 25 Oct 2018 19:14:21 +0100 In-Reply-To: <20181025180403.11073-1-stephen@networkplumber.org> References: <20181025180403.11073-1-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] mlx5: use pkg-config to handle SUSE libmnl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 18:14:24 -0000 On Thu, 2018-10-25 at 11:04 -0700, Stephen Hemminger wrote: > SUSE decided to install the libmnl include file in a non-standard > place: /usr/include/libmnl/libmnl/libmnl.h >=20 > This was probably a mistake by the SUSE package maintainer, > but hard to get fixed. Workaround the problem by pkg-config to find > the necessary include directive for libmnl. >=20 > Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads") > Signed-off-by: Stephen Hemminger > --- > v2 - need --cflags not -cflags >=20 > =C2=A0drivers/net/mlx5/Makefile | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 1e9c0b42ac16..5b0be08ebb81 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -51,6 +51,7 @@ CFLAGS +=3D -D_DEFAULT_SOURCE > =C2=A0CFLAGS +=3D -D_XOPEN_SOURCE=3D600 > =C2=A0CFLAGS +=3D $(WERROR_FLAGS) > =C2=A0CFLAGS +=3D -Wno-strict-prototypes > +CFLAGS +=3D $(pkg-config --cflags libmnl) > =C2=A0ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) > =C2=A0CFLAGS +=3D -DMLX5_GLUE=3D'"$(LIB_GLUE)"' > =C2=A0CFLAGS +=3D -DMLX5_GLUE_VERSION=3D'"$(LIB_GLUE_VERSION)"' > @@ -59,7 +60,7 @@ LDLIBS +=3D -ldl > =C2=A0else > =C2=A0LDLIBS +=3D -libverbs -lmlx5 > =C2=A0endif > -LDLIBS +=3D -lmnl > +LDLIBS +=3D $(pkg-config --libs libmnl) > =C2=A0LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > =C2=A0LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs > =C2=A0LDLIBS +=3D -lrte_bus_pci Acked-by: Luca Boccassi Here's the fix for the SUSE package (CC'ing Marco to make sure I got the process right): https://build.opensuse.org/request/show/644720 --=20 Kind regards, Luca Boccassi