Re: [dpdk-dev] [PATCHv3 0/5] ACL library

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-06-13 12:02, Ananyev, Konstantin:
> 2014-06-13 13:56, Thomas Monjalon:
> > > Konstantin Ananyev (5):
> > >   Add ACL library (librte_acl) into DPDK
> > >   acl: update UT to reflect latest changes in the librte_acl
> > >   acl: New test-acl application
> > >   acl: New sample l3fwd-acl
> > >   acl: add doxygen configuration and start page
> > > 
> > > v2 fixes:
> > > * Fixed several checkpatch.pl issues
> > > * Added doxygen related changes
> > > 
> > > v3 fixes:
> > > * Fixed even more checkpatch.pl issues
> > 
> > Sorry to bother you but after checking v3,
> > 
> > I think these errors should be avoided:
> > 	ERROR: do not use assignment in if condition
> > 	ERROR: return is not a function, parentheses are not required
> 
> These changes would require a lot of changes inside ACL library.
> As I said in cover letter, ACL library was part of IPL code for a while
> (nearly a year).
> I don't really want to make significant changes in it just before the
> release without really good reason - bugs found.

I've made the code style changes, move some configuration lines and added
to BSD build (not tested).
As it was previously acked and tested,
it is now applied for version 1.7.0.

Thanks
-- 
Thomas