From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 4120158FA; Thu, 1 Nov 2018 15:41:59 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id r63-v6so1603881wma.4; Thu, 01 Nov 2018 07:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=86rZXjGPe4AWro7cxRwZlrDZSoa8KIoUm64zpNNtUEY=; b=C+stteJUxdHv4kYKY/b/UUPf4+tVOfpPh8R2t2JLaVCzkyZl8a2QCqKNItquHbrd8I kX+EMdUr0tpp/oSfLBcF8wkUblYfuqHT7M+J2Y1yL1z0N05JYmejilth0g2Yqgg66IRG Zp7V7M+n7wXg5CFzg34t7w7A9GtMIqmHIY8ZEeJM7/q+b57IjLVfce9MvOExepW9pCvk ehjimZ5FuFO7AGoLEkFC1ONdvm/AOOdrmwI2gd/KAivqzIMdO9FdiE9GY7iHcyaNI+JM LQVvjAf0zBYHbQzpy913qNkQzsTsFxshTkdOOzhQIGXkNUV8UL2MswCuAz1LQ+9LKClv jS0Q== X-Gm-Message-State: AGRZ1gLej7Dm3zs0h5yrp80VrWyCH3b9NnenI8sZUQVRH7xPhSwSf94X ps4TYyx/qILK9/D5OxTQw+jzXg1NacM= X-Google-Smtp-Source: AJdET5cXvTNr9aM+VTanPWuyc5k7RYuZGIkR+IExAoeKWUMkzKtPvrt88kR63RcrIL6WXbyvcBP0gA== X-Received: by 2002:a1c:870c:: with SMTP id j12-v6mr6010746wmd.40.1541083318462; Thu, 01 Nov 2018 07:41:58 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:70c5:32f6:c5b6:39e6]) by smtp.gmail.com with ESMTPSA id m192-v6sm13454694wmb.29.2018.11.01.07.41.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 07:41:57 -0700 (PDT) Message-ID: <1541083316.4849.6.camel@debian.org> From: Luca Boccassi To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, qi.z.zhang@intel.com, stable@dpdk.org, ferruh.yigit@intel.com Date: Thu, 01 Nov 2018 14:41:56 +0000 In-Reply-To: <20181101140413.18665-1-bluca@debian.org> References: <20180815170932.23536-1-bluca@debian.org> <20181101140413.18665-1-bluca@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 14:41:59 -0000 On Thu, 2018-11-01 at 14:04 +0000, Luca Boccassi wrote: > ixgbe_identify_phy_x550em() was missing the code to handle > unidentified > PHY that has been there in 82599 so it was not able to complete > initialization of ixgbe sequence if no sfp plugged in. > Port it over to return an appropriate type and complete init sequence > properly. >=20 > Fixes: d2e72774e58c ("ixgbe/base: support X550") > Cc: stable@dpdk.org >=20 > Signed-off-by: Luca Boccassi > --- > v2: refresh to remove merge conflict with master >=20 > =C2=A0drivers/net/ixgbe/base/ixgbe_x550.c | 19 ++++++++++++++++--- > =C2=A01 file changed, 16 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > b/drivers/net/ixgbe/base/ixgbe_x550.c > index f7b98af52..83b394861 100644 Sorry, finger slipped and missed the -v2 from the command so it's not in the subject - it's the same, just rebased to fix a conflict in the first patch. --=20 Kind regards, Luca Boccassi