DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tom Barbette <barbette@kth.se>
To: Shahaf Shuler <shahafs@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	 Andrew Rybchenko <arybchenko@solarflare.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count
Date: Mon, 5 Nov 2018 09:01:03 +0000	[thread overview]
Message-ID: <1541408462940.66979@kth.se> (raw)
In-Reply-To: <DB7PR05MB4426685FAA18491A43449207C3CE0@DB7PR05MB4426.eurprd05.prod.outlook.com>


> It will tell you if in a given offset on the rxq you have a packet ready. I think it will fit your needs, see below.
So we just loose in precision here. We're looking at ML techniques that will play better with a numerical value and benefit from more entropy than arbitrarily poking of some thresholds.
If one had to remain, I'd say rx_descriptor_* should be removed as it can be deduced from queue_count. Moreover, in the MLX5 case, calling the function 3 times to get "half busy", "partially busy" or "idle" will lead to scanning the queue 3 times...

> But for the latency it is better to work w/ NIC host coherent clock + timestamps (like you implemented on a different patch).
We're looking at both as you noticed. But timestamping is much more costly. Hence latency is more for monitoring, reporting to the operator, while queue statistics are used for scheduling. It's harder to understand a latency value as a higher latency may only mean that a bunch of packets were more complex to handle. But we want to look at the relation between the two.

I think this patch should go in (with maybe a solution for vectorized?). And when the removal of queue_count will be discussed I'll follow. But I'm sure other people will jump in the discussion at that time.

Thanks for your time anyway,
Tom

  reply	other threads:[~2018-11-05  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27 15:10 Tom Barbette
2018-10-28  8:58 ` Tom Barbette
2018-10-28  9:37 ` Shahaf Shuler
2018-10-31  9:01   ` Tom Barbette
2018-11-01  7:21     ` Shahaf Shuler
2018-11-05  9:01       ` Tom Barbette [this message]
2018-11-05  9:55         ` Olivier Matz
2018-11-05 13:18           ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541408462940.66979@kth.se \
    --to=barbette@kth.se \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).