DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ranjit Menon <ranjit.menon@intel.com>
Cc: talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com,
	dmitry.kozliuk@gmail.com, david.marchand@redhat.com,
	grive@u256.net
Subject: Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file
Date: Thu, 23 Apr 2020 09:27:56 +0200	[thread overview]
Message-ID: <15414965.hlxOUv9cDv@thomas> (raw)
In-Reply-To: <1248d40a-741d-69ae-a149-4e5b98691f76@intel.com>

23/04/2020 01:51, Ranjit Menon:
> On 4/22/2020 12:27 AM, talshn@mellanox.com wrote:
> > From: Tal Shnaiderman <talshn@mellanox.com>
> > 
> > Move common functions between Unix and Windows to eal_config.c.
> 
> Like other files in common, we should call this eal_common_config.c

I am not sure about the interest of repeating the directory name
in the file name in general.
Do you see a real benefit?

Note: the naming in lib/librte_eal/common/ is not uniform.



  reply	other threads:[~2020-04-23  7:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  7:27 [dpdk-dev] [PATCH 0/7] Windows bus/pci support talshn
2020-04-22  7:27 ` [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file talshn
2020-04-22 23:51   ` Ranjit Menon
2020-04-23  7:27     ` Thomas Monjalon [this message]
2020-04-23  9:06       ` Dmitry Kozlyuk
2020-04-23 10:48         ` Thomas Monjalon
2020-04-23 16:31           ` Ranjit Menon
2020-04-22  7:27 ` [dpdk-dev] [PATCH 2/7] pci: build on Windows talshn
2020-04-22  7:27 ` [dpdk-dev] [PATCH 3/7] eal: add function finding integer in a string talshn
2020-04-22  7:27 ` [dpdk-dev] [PATCH 4/7] drivers: ignore pmdinfogen generation for Windows talshn
2020-04-22  7:27 ` [dpdk-dev] [PATCH 5/7] drivers: fix incorrect meson import folder " talshn
2020-04-22  7:27 ` [dpdk-dev] [PATCH 6/7] bus/pci: introduce Windows support with stubs talshn
2020-04-22  7:27 ` [dpdk-dev] [PATCH 7/7] bus/pci: support Windows with bifurcated drivers talshn
2020-04-27 22:58   ` Narcisa Ana Maria Vasile
2020-04-28  8:11     ` Tal Shnaiderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15414965.hlxOUv9cDv@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=grive@u256.net \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).