From: Li Han <han.li1@zte.com.cn> To: reshma.pattan@intel.com Cc: dev@dpdk.org, Li Han <han.li1@zte.com.cn> Subject: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue Date: Wed, 7 Nov 2018 01:10:09 -0500 Message-ID: <1541571009-12396-1-git-send-email-han.li1@zte.com.cn> (raw) parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") Signed-off-by: Li Han <han.li1@zte.com.cn> --- v3: *fix commit meassges issue v2: *fix typecast issue --- app/proc-info/main.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c20effa..650d599 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -37,7 +37,7 @@ #define MAX_STRING_LEN 256 /**< mask of enabled ports */ -static uint32_t enabled_port_mask; +static uint64_t enabled_port_mask; /**< Enable stats. */ static uint32_t enable_stats; /**< Enable xstats. */ @@ -90,7 +90,7 @@ /* * Parse the portmask provided at run time. */ -static int +static unsigned long parse_portmask(const char *portmask) { char *end = NULL; @@ -103,12 +103,9 @@ if ((portmask[0] == '\0') || (end == NULL) || (*end != '\0') || (errno != 0)) { printf("%s ERROR parsing the port mask\n", __func__); - return -1; + return 0; } - if (pm == 0) - return -1; - return pm; } -- 1.8.3.1
next reply other threads:[~2018-11-07 6:41 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-07 6:10 Li Han [this message] 2018-11-07 9:47 ` Pattan, Reshma 2018-11-14 3:10 ` Thomas Monjalon 2018-11-14 3:57 ` [dpdk-dev] 答复: " han.li1 2018-11-14 10:39 ` [dpdk-dev] " Burakov, Anatoly 2018-11-16 10:15 ` Burakov, Anatoly 2018-11-16 10:35 ` Burakov, Anatoly
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1541571009-12396-1-git-send-email-han.li1@zte.com.cn \ --to=han.li1@zte.com.cn \ --cc=dev@dpdk.org \ --cc=reshma.pattan@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git