From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20057.outbound.protection.outlook.com [40.107.2.57]) by dpdk.org (Postfix) with ESMTP id 166242BB1 for ; Wed, 7 Nov 2018 15:09:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JMZyaWg6xtiZwWqDqFSIgHRqVPJK1Mz4RRJ00VIJaU=; b=bHcHhbb32hnZOR5vFOTWFKIUKg1Weie4T9aHP0O6Q1lcg4ADziAabXCqbhaIsuJJndPCS0tw1HvTtp9e31vEaeVnHsIx8hv2y0x/CHwrz9bwrWFhpmm7fiv8dSMTiqTGpG2T8Fdh6p4Wcy2jyOu8yoS9BeGYjgTArAlOEAiW/VQ= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.92.20) by AM0PR05MB5939.eurprd05.prod.outlook.com (20.178.119.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.27; Wed, 7 Nov 2018 14:09:28 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::f5c5:3abe:8819:7aeb]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::f5c5:3abe:8819:7aeb%3]) with mapi id 15.20.1294.034; Wed, 7 Nov 2018 14:09:28 +0000 From: Mordechay Haimovsky To: "david.hunt@intel.com" CC: "dev@dpdk.org" , "radu.nicolau@intel.com" , Mordechay Haimovsky Thread-Topic: [PATCH] examples/l3fwd-power: fix prog exit on ini pwr lib Thread-Index: AQHUdqN/Vgw+RNw950uuiLyO1hqmQg== Date: Wed, 7 Nov 2018 14:09:28 +0000 Message-ID: <1541599750-18432-1-git-send-email-motih@mellanox.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP123CA0102.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:5f::18) To AM0PR05MB4435.eurprd05.prod.outlook.com (2603:10a6:208:5a::20) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR05MB5939; 6:E8oxsQvhP+GqcrPRt2SXdGgctqQM/nIwc+joQfjAl5AadCwZqhhio5JzX+F2aQGMf1+xJbVtlgl3wMn5Nb0yFoFw8r3yQWJiiUUROp3RMGetuP9xPyKtyQdRJ02u+X9RO2jGVtkVTVpZ6y46nPVTESfJ6QDq9F+4C67bVOiPlvgfoWAA4EwHhhH8IhcSrFMER0DOVViEJzCvUbVPYUwoXOqzp1txNnlpXl5OEDadgfsmFePZs4XMBMuUWL+BpUKPx6tyhbXfgX7uRUQ+yYs4mQLyNN9StgqD+HFK8YEN06FY4Bj3Y3barGJKMIncmV4c9EfmFDq1k/iwQFAWttZRdzJC/pimCTdxTh8jTQBwFbPJcR5QF2AtZx3Go17FpItNZ1xM7mOKDv1QSdiZ0g8sHDb/LW4IPkblRycHkM9F9o8EkGmhdFuT+7Qq4I5iIExsVfFK7VWHxyAzpOVt6lgTBA==; 5:5sgqOBSNUlnw9Dq0TIZVcaP3LiVhebk6EQYgtZLjfoR6dk5FixwaR3EzqMqKkXFj6i1OdL2PoktWrIsyFfFnsp6GO6vR6usXiBbi4VLp0TwTB2lYN4Y0ivWZnidoFnu4hzkAinHP7aArs3H16dBuHMAlknistLT+jcsJdylDkOQ=; 7:OoxtlqhxI008Z/UHV96tPcaXmfTZ/PNMnAcotYpifZ3ao3/4vWTQdG+wTvjn0qjwCZVq8XgkrV71ByhzxNKEnYz5L0BBOSIx6VDEyOjsH8RZUGF5SyviFsz4+qjYqn4xVLz21K0juGVJGkJsvWsJ7A== x-ms-office365-filtering-correlation-id: e4e47196-93dc-4535-3d6f-08d644baa140 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB5939; x-ms-traffictypediagnostic: AM0PR05MB5939: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM0PR05MB5939; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB5939; x-forefront-prvs: 08497C3D99 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(39860400002)(376002)(136003)(189003)(199004)(14444005)(14454004)(256004)(36756003)(66066001)(6916009)(105586002)(106356001)(71190400001)(71200400001)(2351001)(4326008)(52116002)(316002)(54906003)(102836004)(97736004)(2900100001)(6116002)(3846002)(26005)(6512007)(1857600001)(8676002)(81156014)(81166006)(8936002)(478600001)(2501003)(68736007)(6506007)(386003)(25786009)(5660300001)(186003)(305945005)(53936002)(2906002)(99286004)(6436002)(5640700003)(86362001)(7736002)(486006)(107886003)(476003)(2616005)(6486002)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5939; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: T6atzXvPE8GPaKbvEbdqElM2ZPOwYIKE2ugrPNj2IXd9qZ9Tz4dY7os5esqwzCnajY8f1iIBFDZYEuAggFmLDipJ2qaN7djsD4norx1xBrsLxhGVa2D6P/S84p/F6+Ri2G0kOm1q85pksb8JacYifeP8WQkbn8/t4LqexBp5KAiwvYSZZ3HF22Sr+jrCbA3MK1KY26S/Uc5yUklDZy4v78S3H2IxP2qOXzBsvzxU9dzvZLd5N3GnJJRX6HQmZPTL0h57e5bwhHC0Y8YTutG10XqgXwzea4C/+69KU4WFqL36cWm/mT1xP2ToUgCiZj3cOIMaN+xOtPWjHnL0ns13FTWJ9x5rbS5rwZUHxVDnxpk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4e47196-93dc-4535-3d6f-08d644baa140 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2018 14:09:28.6526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5939 Subject: [dpdk-dev] [PATCH] examples/l3fwd-power: fix prog exit on ini pwr lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 14:09:30 -0000 This patch replaces the rte_exit routine with error printing when init_power_library() fails and by that restores the previous behavior of the program (which was to issue an error message and continue working if init_power_library fails). This allows the user to still experience the Rx interrupts feature of the DPDK demonstrated in this program. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores opt= ions") Cc: radu.nicolau@intel.com Signed-off-by: Moti Haimovsky --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 0b3f8fe..9c7b315 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1957,7 +1957,7 @@ static int check_ptype(uint16_t portid) rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); =20 if (init_power_library()) - rte_exit(EXIT_FAILURE, "init_power_library failed\n"); + RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n"); =20 if (update_lcore_params() < 0) rte_exit(EXIT_FAILURE, "update_lcore_params failed\n"); --=20 1.8.3.1