DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shaopeng He <shaopeng.he@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: support XEN domain0
Date: Fri, 15 May 2015 12:21:04 +0200	[thread overview]
Message-ID: <1541656.ZXuqYTxN13@xps13> (raw)
In-Reply-To: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com>

Hi,

2015-05-15 16:56, Shaopeng He:
> +#ifdef RTE_LIBRTE_XEN_DOM0
> +	q->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);
> +#else
>  	q->hw_ring_phys_addr = mz->phys_addr;
> +#endif

I know this is already done this way in other drivers, but don't you think
it's time to create a function to get physical address from a memzone?
So we could remove these "ifdef Xen" from every drivers.

Thanks

  reply	other threads:[~2015-05-15 10:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15  8:56 Shaopeng He
2015-05-15 10:21 ` Thomas Monjalon [this message]
2015-05-15 23:57 ` Stephen Hemminger
2015-05-18  2:23   ` Liu, Jijiang
2015-06-02  3:27     ` He, Shaopeng
2015-06-05  3:17 ` Liu, Jijiang
2015-06-23  1:21   ` He, Shaopeng
2015-06-30  3:27     ` He, Shaopeng
2015-07-01 10:47       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541656.ZXuqYTxN13@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=shaopeng.he@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).