From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 06FBA376C
 for <dev@dpdk.org>; Fri, 15 May 2015 12:21:48 +0200 (CEST)
Received: by wgnd10 with SMTP id d10so105300517wgn.2
 for <dev@dpdk.org>; Fri, 15 May 2015 03:21:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=xZOFhfq+Gv0qlElwfGhCLs1lEi5u+NuhhivfbzzYp3E=;
 b=Iyd2jF0Bl5rHcdFOfZoG1QMJWLJQU5F4w8YOdazz7yzFaYlY18RU/A8dIU3db5OLn6
 MDtnyIcxJIVnksseen8SU/qNJOdr+hqc8JpK3dvOvojm/dQ0PLlHbasNV/M4VbE7jA2Y
 nqQx1pTK03an6uJeFVXSBc62SJaFs1QIddjPwPTNCIBQB2Sv1qA5l+PKr7euWow84ZtA
 caL16/W96dY9/vYIaEUPbzuKC1IqGp/dK1Tv8JVoKDyMGNHMlAXHyh9eesubAOFwE5FR
 aFmYHuMNZnOhbQEZ4My5aQSeaEuEc0Ekv5+4h74Zo+3uNqD9m5SpAvvMLLiHbSLeffU3
 5Q+Q==
X-Gm-Message-State: ALoCoQmZVFIFYto+4qx43wGNg7cGpdvMCeoLu8SxzeOS3MU90VnsPVYGoNhdHrMv6/vSlD33IHwr
X-Received: by 10.194.81.234 with SMTP id d10mr8467571wjy.84.1431685307777;
 Fri, 15 May 2015 03:21:47 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gw7sm2535547wib.15.2015.05.15.03.21.46
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 15 May 2015 03:21:47 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shaopeng He <shaopeng.he@intel.com>
Date: Fri, 15 May 2015 12:21:04 +0200
Message-ID: <1541656.ZXuqYTxN13@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com>
References: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: support XEN domain0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 May 2015 10:21:48 -0000

Hi,

2015-05-15 16:56, Shaopeng He:
> +#ifdef RTE_LIBRTE_XEN_DOM0
> +	q->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);
> +#else
>  	q->hw_ring_phys_addr = mz->phys_addr;
> +#endif

I know this is already done this way in other drivers, but don't you think
it's time to create a function to get physical address from a memzone?
So we could remove these "ifdef Xen" from every drivers.

Thanks