DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anoob Joseph <anoob.joseph@caviumnetworks.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: "Joseph, Anoob" <Anoob.Joseph@cavium.com>,
	"Jacob,  Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
	"Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
	"Dwivedi, Ankur" <Ankur.Dwivedi@cavium.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH 3/3] crypto/octeontx: fix null pointer dereferencing
Date: Sun, 11 Nov 2018 15:24:42 +0000	[thread overview]
Message-ID: <1541949837-9629-4-git-send-email-anoob.joseph@caviumnetworks.com> (raw)
In-Reply-To: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com>

The function otx_cpt_get_resource() would be setting the pointer
'instance'. In case of error, 'instance' would be set to NULL, and
returns rte_errno. If rte_errno when 'instance' is set to NULL, it can
lead to NULL pointer dereferencing.

Fixes: 0961348fdf52 ("crypto/octeontx: add queue pair functions")

Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
---
 drivers/crypto/octeontx/otx_cryptodev_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c
index 23f9659..90d0c14 100644
--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
@@ -216,7 +216,7 @@ otx_cpt_que_pair_setup(struct rte_cryptodev *dev,
 	}
 
 	ret = otx_cpt_get_resource(cptvf, 0, &instance);
-	if (ret != 0) {
+	if (ret != 0 || instance == NULL) {
 		CPT_LOG_ERR("Error getting instance handle from device %s : "
 			    "ret = %d", dev->data->name, ret);
 		return ret;
-- 
2.7.4

  parent reply	other threads:[~2018-11-11 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 15:24 [dpdk-dev] [PATCH 0/3] fixing coverity reported issues Anoob Joseph
2018-11-11 15:24 ` [dpdk-dev] [PATCH 1/3] crypto/octeontx: fix non null terminated string Anoob Joseph
2018-11-11 15:24 ` [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing Anoob Joseph
2018-11-12 11:20   ` Akhil Goyal
2018-11-12 11:23     ` Joseph, Anoob
2018-11-12 11:45       ` Akhil Goyal
2018-11-11 15:24 ` Anoob Joseph [this message]
2018-11-12 18:14 ` [dpdk-dev] [PATCH v2] crypto/octeontx: fix coverity issues Anoob Joseph
2018-11-13 10:12   ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541949837-9629-4-git-send-email-anoob.joseph@caviumnetworks.com \
    --to=anoob.joseph@caviumnetworks.com \
    --cc=Ankur.Dwivedi@cavium.com \
    --cc=Anoob.Joseph@cavium.com \
    --cc=Jerin.JacobKollanukkaran@cavium.com \
    --cc=NarayanaPrasad.Athreya@cavium.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).