From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 714BD201 for ; Mon, 12 Nov 2018 10:42:56 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id u5-v6so3240329wrn.9 for ; Mon, 12 Nov 2018 01:42:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=0qKwJgnpL+XjL8a+V+xemI5TNzvUBoHTViK3/8Dn7/o=; b=D7/R1m0XUemuKVjWzSO6xMmVN3JU3hoWIbgQKYZcKG1sDg0upgxAgZ+NIzicxmvXm9 9NZW8hBkKdZKagRhGFznXI5CjcjFIuVuj8SdQ8iGWJuQ07qhuWg0byRUZTat7UG3a3cP FmUXl3LGFjjibxKCbGwhRZcadJ9+l+Wk8vuOlwBZtIN1D2gAU+WI0dXoCteUJNbj+zQy YFA5//Cz3lyVF1RcTQ7tcwIfQ/++ak1Mt4oOwO4YE4DoWgZml43tsyr/0l++ZdkB5MH7 LWnvOVNilrq/GpAKdlrHzRGs8+kA2Qw9Fv2d5NrrWlolHGD1ZrboStx7ibuoyHnxy6PT R3Dw== X-Gm-Message-State: AGRZ1gJceOZ9BhCqP4eMN18TwKsIJ5CJIyfH1sBoQq8lORKHDEIcwezo b/HfdGVAP9BjEZbe+oa9K0Q= X-Google-Smtp-Source: AJdET5dkEZZrmG0XYbzJZU0EApdNVzSQ2uTlgjT1rVsPlJyqtaqiKId+K78NZpWs+E4q1bdV6ctheg== X-Received: by 2002:adf:9123:: with SMTP id j32-v6mr290523wrj.0.1542015775883; Mon, 12 Nov 2018 01:42:55 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id k66-v6sm12812289wmd.47.2018.11.12.01.42.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Nov 2018 01:42:55 -0800 (PST) Message-ID: <1542015769.11515.0.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , dev@dpdk.org Cc: ferruh.yigit@intel.com, ophirmu@mellanox.com, mk@semihalf.com Date: Mon, 12 Nov 2018 09:42:49 +0000 In-Reply-To: <20181111224611.19234-1-thomas@monjalon.net> References: <20181111224611.19234-1-thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] drivers/net: set close behaviour flag at probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 09:42:56 -0000 On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote: > The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers > having migrated to the new behaviour of rte_eth_dev_close(). >=20 > As any other flag, it can be useful to know about its value > as soon as the port is probed. > Unfortunately, it was set inside the close operation, > just before being erased by memset() in rte_eth_dev_release_port(). > The flag assignment is moved to the probing stage, so it can > be checked by the application in order to anticipate the behaviour. >=20 > Fixes: 42603bbdb58e ("net/mlx5: release port on close") > Cc: ophirmu@mellanox.com > Fixes: 6c99085d972b ("net/vmxnet3: fix hot-unplug") > Cc: bluca@debian.org > Fixes: 4d7877fde2ef ("net/ena: remove resources when port is being > closed") > Cc: mk@semihalf.com >=20 > Signed-off-by: Thomas Monjalon > --- > =C2=A0drivers/net/ena/ena_ethdev.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0| 11 ++++++----- > =C2=A0drivers/net/mlx5/mlx5.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A07 ++----- > =C2=A0drivers/net/vmxnet3/vmxnet3_ethdev.c |=C2=A0=C2=A09 +++------ > =C2=A03 files changed, 11 insertions(+), 16 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi