From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 061ACB6D for ; Mon, 28 Nov 2016 11:54:26 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id f82so150821747wmf.1 for ; Mon, 28 Nov 2016 02:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=GGfIZdyg6o9ySpEoQKsQFYmo8xDAJf2T4XbIrAx5qtM=; b=sV5dfrP3Pd/BIF+WEptlaAKD5OBysaZ8JRg+1naGLlep1wCItnILGGydO/HZhRrYQq oOJIs1zD3gcBuCwiN7CXWPkZhYr3huaOhxB/6qsbpZ2WUt+GRLdMALIIMUSUtpEvEhSB MyygQZf2nIyofOJuJfb2VUSQeQH0DabzFteU8KKSAdSwHsgHGwZQDPf2i7rZBx14kCbS b+J7uuuMb+nnv5DgpR6jMO9oetam3GrH8uwK7vQ92bprfFYKb4f9ew5WgcofGKTX8v8Y bxSOh8qL/ouIUC1v69UbeWAY6yXTduIWAqHl+5wVcDKmZYrvdz429w4nZVrN6t9ZpEnF wlXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GGfIZdyg6o9ySpEoQKsQFYmo8xDAJf2T4XbIrAx5qtM=; b=MEMkZLEXxhQKk0CEJg/pXZAqHG1w7U+Ua7xyct8xPTN847dmn57B+2tedxYraOshH5 5cBPG4+jdfi/iYu9eGGjJZqZBjQ0lJ+cE7wfaz3Yurv623Q4V+Xkj9Pv8wbJcVsIQxd8 vaGeS4D2rhRFvFNUfrIBvEdvkrGOPUq9z+YmYFJEpmuvVemMHFU/kNvv+jziDUPkxWGj W6JvfjjqJKhjELtUGILxqSv8M+ViVPKqUq8xUnx3TQuXy1Fn6TmMgjSGYfEfEz1CjQEw SAdJYoTv+FE1oQqVRRr3TB4hJv3rOWdgTT6ASVGd9V3WVKXV2JaqHi8k7jJ9CpL8CodC 8OgQ== X-Gm-Message-State: AKaTC02OuD3CHf688/QvL5v8d/xu2a39NZtugGxovOm1crD+dAsTogEhbZWgKUmTX8ecwYSU X-Received: by 10.28.10.147 with SMTP id 141mr18085264wmk.65.1480330466658; Mon, 28 Nov 2016 02:54:26 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d8sm28216810wmi.21.2016.11.28.02.54.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2016 02:54:25 -0800 (PST) From: Thomas Monjalon To: Tomasz Kulasek Cc: dev@dpdk.org, konstantin.ananyev@intel.com, olivier.matz@6wind.com, bruce.richardson@intel.com Date: Mon, 28 Nov 2016 11:54:25 +0100 Message-ID: <15420823.7ghYzVRe3h@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1479922585-8640-2-git-send-email-tomaszx.kulasek@intel.com> References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-2-git-send-email-tomaszx.kulasek@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2016 10:54:27 -0000 Hi, 2016-11-23 18:36, Tomasz Kulasek: > --- a/config/common_base > +++ b/config/common_base > @@ -120,6 +120,7 @@ CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 > CONFIG_RTE_LIBRTE_IEEE1588=n > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y > +CONFIG_RTE_ETHDEV_TX_PREPARE=y Please, remind me why is there a configuration here. It should be the responsibility of the application to call tx_prepare or not. If the application choose to use this new API but it is disabled, then the packets won't be prepared and there is no error code: > +#else > + > +static inline uint16_t > +rte_eth_tx_prepare(__rte_unused uint8_t port_id, __rte_unused uint16_t queue_id, > + __rte_unused struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > +{ > + return nb_pkts; > +} > + > +#endif So the application is not aware of the issue and it will not use any fallback.