From: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com> To: dev@dpdk.org Cc: byron.marohn@intel.com, reshma.pattan@intel.com, pablo.de.lara.guarch@intel.com, Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>, stable@dpdk.org Subject: [dpdk-dev] [PATCH] lib: fix write unlock during ring creation Date: Tue, 13 Nov 2018 12:55:14 +0000 Message-ID: <1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com> (raw) In-Reply-To: <y> In rte_efd_create() write lock has already been unlocked before ring creation itself. So second unlock after the ring creation has been removed and added freeing of tail queue entry and efd table. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: stable@dpdk.org Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com> --- lib/librte_efd/rte_efd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index a780e2fe8..0c7ce9612 100644 --- a/lib/librte_efd/rte_efd.c +++ b/lib/librte_efd/rte_efd.c @@ -687,12 +687,13 @@ rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK); snprintf(ring_name, sizeof(ring_name), "HT_%s", table->name); - /* Create ring (Dummy slot index is not enqueued) */ + /* Create ring (Dummy slot index is not enqueued) */ r = rte_ring_create(ring_name, rte_align32pow2(table->max_num_rules), offline_cpu_socket, 0); if (r == NULL) { RTE_LOG(ERR, EFD, "memory allocation failed\n"); - goto error_unlock_exit; + rte_efd_free(table); + return NULL; } /* Populate free slots ring. Entry zero is reserved for key misses. */ -- 2.13.6
next reply other threads:[~2018-11-13 12:55 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-13 12:55 Chaitanya Babu Talluri [this message] 2018-11-13 16:58 ` Pattan, Reshma 2018-11-18 14:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2018-11-14 11:24 ` [dpdk-dev] [PATCH v2] lib/efd: " Chaitanya Babu Talluri 2018-11-16 13:39 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2018-11-18 14:46 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com \ --to=tallurix.chaitanya.babu@intel.com \ --cc=byron.marohn@intel.com \ --cc=dev@dpdk.org \ --cc=pablo.de.lara.guarch@intel.com \ --cc=reshma.pattan@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git