From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E083591; Tue, 13 Nov 2018 16:03:03 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 862A01000A9; Tue, 13 Nov 2018 15:03:01 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 13 Nov 2018 07:02:58 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 13 Nov 2018 07:02:57 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wADF2uQ9026217; Tue, 13 Nov 2018 15:02:56 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 8FBB21616EF; Tue, 13 Nov 2018 15:02:56 +0000 (GMT) From: Andrew Rybchenko To: CC: Igor Romanov , Date: Tue, 13 Nov 2018 15:02:44 +0000 Message-ID: <1542121364-29021-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24218.006 X-TM-AS-Result: No-3.324900-4.000000-10 X-TMASE-MatchedRID: bk2QpUPDfampVRk1aVTtmpN65fjGjYMQcbniFtnyrsgAhmnHHeGnvVO4 BD7nLMxnqQSZBgEX4IihI3awKlxWqNvWh31RtNY8ngIgpj8eDcAZ1CdBJOsoY8RB0bsfrpPIcSq bxBgG0w4OneQLEa9xI0IVNE2MWB24jK5wc58M4S7ntMcYbpZYYM/obcDGx1/1mDdXaFAELnViuy OwV51BtC1oFndlcZYF13NJPp74HrWTdSRXlCnjBIjjlF305EnAWUm8SESyzd/NBqGt1DPvvA== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.324900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24218.006 X-MDID: 1542121382-x5NDEnBRNFfH Subject: [dpdk-dev] [PATCH] net/sfc/base: fix field order in filter spec struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 15:03:04 -0000 From: Igor Romanov Fields in the struct efx_filter_spec_t starting from efs_outer_vid are hashed for software filter lookup. efs_mark is not a matching criteria. Exclude efs_mark from hash. Fixes: 5f78af523912 ("net/sfc: support MARK and FLAG actions in flow API") Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h index 8e10e8934..2e847b6ce 100644 --- a/drivers/net/sfc/base/efx.h +++ b/drivers/net/sfc/base/efx.h @@ -2878,6 +2878,8 @@ typedef struct efx_filter_spec_s { efx_filter_flags_t efs_flags; uint16_t efs_dmaq_id; uint32_t efs_rss_context; + uint32_t efs_mark; + /* Fields below here are hashed for software filter lookup */ uint16_t efs_outer_vid; uint16_t efs_inner_vid; uint8_t efs_loc_mac[EFX_MAC_ADDR_LEN]; @@ -2891,7 +2893,6 @@ typedef struct efx_filter_spec_s { efx_oword_t efs_loc_host; uint8_t efs_vni_or_vsid[EFX_VNI_OR_VSID_LEN]; uint8_t efs_ifrm_loc_mac[EFX_MAC_ADDR_LEN]; - uint32_t efs_mark; } efx_filter_spec_t; -- 2.17.1